Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support Django5 - This blocks upgrades #120

Closed
duaneking opened this issue Dec 4, 2023 · 6 comments
Closed

Does not support Django5 - This blocks upgrades #120

duaneking opened this issue Dec 4, 2023 · 6 comments

Comments

@duaneking
Copy link

This lack of support for Django 5 is blocking upgrades.

@duaneking duaneking changed the title Does not support Djago5 - This blocks upgrades Does not support Django5 - This blocks upgrades Dec 4, 2023
@mfogel
Copy link
Owner

mfogel commented Dec 5, 2023

hum, I'm confused. The latest release should support django 5.0. As far as I know django 5.0 is included in all the right places in pyproject.toml... and pypi seems to think it django 5.0 is supported.

What issue exactly are you running into? Maybe something got missed?

@mfogel
Copy link
Owner

mfogel commented Dec 6, 2023

@duaneking are you still running into issues with django 5?

@tuky
Copy link

tuky commented Dec 6, 2023

Yes, should be fine. It might be another library that is using this one here. e.g. django-bootstrap-datepicker-plusstill depends on django < 5

@cclauss
Copy link
Contributor

cclauss commented Dec 7, 2023

For me, the downgrade was caused by celery/django-celery-beat#698

@duaneking
Copy link
Author

It looks like somebody on your side did a silent update; the package seems to work now. Before, attempts to do so got an error saying the package did not support django5.

If you get this error, I suggest you update this package first, then update Django to 5 as pip might complain otherwise.

@cclauss
Copy link
Contributor

cclauss commented Dec 9, 2023

I think this can be closed.

(.venv) ➜ dj5-hack python -m pip install django-timezone-field==6.1.0
(.venv) ➜ dj5-hack python -m pipdeptree

django-timezone-field==6.1.0
└── Django [required: >=3.2,<6.0, installed: 5.0]
    ├── asgiref [required: >=3.7.0, installed: 3.7.2]
    └── sqlparse [required: >=0.3.1, installed: 0.4.4]

It might be another library that is using this one here. e.g. django-bootstrap-datepicker-plus

@tuky django-bootstrap-datepicker-plus has Dj5 issues but it does not depend on django-timezone-field
(.venv) ➜ dj5-hack pip install django-bootstrap-datepicker-plus==5.0.4
(.venv) ➜ dj5-hack python -m pipdeptree

django-bootstrap-datepicker-plus==5.0.4
├── Django [required: >=2,<5, installed: 4.2.8]
│   ├── asgiref [required: >=3.6.0,<4, installed: 3.7.2]
│   └── sqlparse [required: >=0.3.1, installed: 0.4.4]
├── pydantic [required: Any, installed: 2.5.2]
│   ├── annotated-types [required: >=0.4.0, installed: 0.6.0]
│   ├── pydantic-core [required: ==2.14.5, installed: 2.14.5]
│   │   └── typing-extensions [required: >=4.6.0,!=4.7.0, installed: 4.8.0]
│   └── typing-extensions [required: >=4.6.1, installed: 4.8.0]
└── typing-extensions [required: Any, installed: 4.8.0]

@mfogel mfogel closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants