Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django 5.0 #698

Closed
qengine13 opened this issue Dec 5, 2023 · 24 comments · Fixed by #712
Closed

django 5.0 #698

qengine13 opened this issue Dec 5, 2023 · 24 comments · Fixed by #712

Comments

@qengine13
Copy link

Installed django 5.0. and got the warning that celery beat 2.5.0 not compatible... Will there be an update?

@aminvsf
Copy link

aminvsf commented Dec 5, 2023

I was wondering the same thing. It's the only package among my other dependencies which is incompatible.

@piotr-grzelka
Copy link

#681

@tuky
Copy link

tuky commented Dec 6, 2023

So it only needs a new release? Considering how simple the patch was, I would suggest to loosen the deps a little bit and at least support Django < 6 and not only Django < 5.1. Nobody can tell the future, but IMO package maintainers should focus on the minimum dependency versions and packages users on maximum dependency versions.

@Koff
Copy link

Koff commented Dec 6, 2023

Any idea on when a new package version is being released on PIP?

@cclauss
Copy link
Contributor

cclauss commented Dec 7, 2023

% python3.12 -m venv .venv
% source .venv/bin/activate
% pip install --upgrade pip
% pip install django==5.0 django-celery-beat==2.5.0 --> Failure
% pip install django==5.0 django-celery-beat --> Success but with

  • django-celery-beat downgraded 2.5.0 --> v2.1.0 and
  • django-timezone-field downgraded from v6.1.0--> v4.2.3

Please release a new version to PyPI.

@hansegucker
Copy link

A release would be very great to bring forward our own release.

@tuky
Copy link

tuky commented Dec 18, 2023

Of course, we're all free to (temporarily) exclude this package from our requirements locking pipeline and install our deps something like this:

.../pipenv install --system --deploy
.../pip install python-crontab>=2.3.4 cron-descriptor>=1.2.32
.../pip install django-celery-beat==2.5.0 --no-dependencies

@JulianTenschert
Copy link

JulianTenschert commented Dec 18, 2023

% python3.12 -m venv .venv % source .venv/bin/activate % pip install --upgrade pip % pip install django==5.0 django-celery-beat==2.5.0 --> Failure % pip install django==5.0 django-celery-beat --> Success but with

  • django-celery-beat downgraded 2.5.0 --> v2.1.0 and
  • django-timezone-field downgraded from v6.1.0--> v4.2.3

Please release a new version to PyPI.

Thanks. Using django-celery-beat without a version specifier is a good workaround.

@cclauss
Copy link
Contributor

cclauss commented Dec 25, 2023

This repo's tests pass on CPython and Django v5 but they fail on PyPy3.10 and Django v5. Help needed.

Running on old versions of django-celery-beat and django-timezone-field is probably not a good idea.

@ddoroshev
Copy link

This repo's tests pass on CPython and Django v5 but they fail on PyPy3.10 and Django v5. Help needed.

Done #708. Long story short: a bug in PyPy 3.10-7.3.13.

@esauser
Copy link

esauser commented Jan 5, 2024

When can we expect a new release?

@Nigel2392
Copy link

Nigel2392 commented Jan 9, 2024

Am I seeing this right, is Django 5.1 not going to be supported in the upcoming release? Don't think they're going to make any breaking changes in a minor... https://docs.djangoproject.com/en/dev/releases/5.1/#backwards-incompatible-5-1

@AlexEnrique
Copy link

@cclauss
Copy link
Contributor

cclauss commented Jan 9, 2024

https://github.com/celery/django-celery-beat/pulls?q=is%3Apr+author%3Acclauss+is%3Aclosed fixed the timzone issues that I could find and Py5.0 tests https://github.com/celery/django-celery-beat/blob/main/tox.ini#L15 pass at https://github.com/celery/django-celery-beat/actions/workflows/test.yml

Let's focus on getting a release on PyPI that supports Django v5.0 (shipping) before we focus too much on Django 5.1 (NOT shipping).

@amweiss
Copy link
Contributor

amweiss commented Jan 13, 2024

Any news here? The issue was closed, but no release was made.

@Nigel2392
Copy link

Nigel2392 commented Jan 14, 2024

Any news here? The issue was closed, but no release was made.

There was a release made, it got deleted.
Perhaps they caught a bug.

edit
#680 (comment)

@amweiss
Copy link
Contributor

amweiss commented Jan 14, 2024

There was a release made, it got deleted. Perhaps they caught a bug.

edit #680 (comment)

The Django 5 tests passed in this package, so I'm not sure if that's related. But per the comment, I made a PR to resolve the base celery deprecation warnings: celery/celery#8791

@ribeaud
Copy link

ribeaud commented Jan 22, 2024

Any news here? Waiting for a v2.6.0 release (and I am probably not the only one 😬)...

@ddahan
Copy link

ddahan commented Jan 22, 2024

Please stop posting "any news ?" messages many times. At least 3 reasons to NOT do this:

  • The maintainers are totally aware there is a release to do, so if they don't do it, they have a reason. Pushing them does not help, and is not respectful.
  • You decided to upgrade to Django 5.0 without being forced to. Being an early adopter means lots of packages are not compatible at day one, so please consider downgrade or think carefully next time before upgrading.
  • It sends an email to lots of people (and yes, sorry for doing the same because of this message).

@ribeaud
Copy link

ribeaud commented Jan 22, 2024

Please stop posting "any news ?" messages many times. At least 3 reasons to NOT do this:

  • The maintainers are totally aware there is a release to do, so if they don't do it, they have a reason. Pushing them does not help, and is not respectful.
  • You decided to upgrade to Django 5.0 without being forced to. Being an early adopter means lots of packages are not compatible at day one, so please consider downgrade or think carefully next time before upgrading.
  • It sends an email to lots of people (and yes, sorry for doing the same because of this message).

I do not think anything more than this statement was needed (at least for me). I did not see here any clear post about a release happening soonish, or not so soonish. Thanks a lot for the quick answer. Very appreciated. And oops sorry, I did it again (disturbing a lot of people...).

@adampl
Copy link

adampl commented Jan 24, 2024

You decided to upgrade to Django 5.0 without being forced to. Being an early adopter means lots of packages are not compatible at day one

Personally I don't care about Django version, I'm just waiting for the bugfixes. Delaying the release by months just because of Django means that there's something wrong with the release plan...
When nobody provides any ETA, you shouldn't be surprised that people will keep asking. If you want to release some of the pressure, consider releasing a 2.5.x patch version with the long overdue bugfixes.

@trAve3113r
Copy link

People shouldn't make such strong demands for an open source project run by people who volunteer their time. If it's a paid subscription, yeah... you're free to demand value for money.

@Nigel2392
Copy link

People shouldn't make such strong demands for an open source project run by people who volunteer their time. If it's a paid subscription, yeah... you're free to demand value for money.

@cclauss yes, I guess I'm wondering what else needs to happen before a maintainer tags and releases as we have all been using it from the git repo for a while now without issues. If there's some further evidence needed I'm happy to supply it. We have been running against the git version for about 4 weeks now without issue.

Originally posted by @amweiss in #680 (comment)

Remind me, what is the strong demand here? Don't revive a dead issue.

@cclauss
Copy link
Contributor

cclauss commented Feb 5, 2024

This issue is closed and should be locked by a maintainer.
Discussion should move to #680 (open) which has a title that describes what is still left to do.

@celery celery locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.