Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions and PyPy 3.10 and Django 5.0 #699

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 6, 2023

Upgrading our project from Django v4.2 to v5.0 downgraded our versions of django-celery-beat and django-timezone-field!

Pipfile.lock:

        "django-celery-beat": {
            [ ... ]
-           "version": "==2.5.0"
+           "version": "==2.1.0"
        },

% python3.12 -m venv .venv
% source .venv/bin/activate
% pip install --upgrade pip
% pip install django==5.0 django-celery-beat==2.5.0 --> Failure
% pip install django==5.0 django-celery-beat --> Success but with

  • django-celery-beat downgraded 2.5.0 --> v2.1.0 and
  • django-timezone-field downgraded from v6.1.0--> v4.2.3

Please release a new version to PyPI.

@cclauss cclauss changed the title Upgrade GitHub Actions and PyPy Upgrade GitHub Actions and PyPy3.10 and Django v5.0 Dec 6, 2023
@cclauss
Copy link
Contributor Author

cclauss commented Dec 9, 2023

@auvipy Can you please approve the workflow runs so I can see if these tests pass?

@Koff
Copy link

Koff commented Dec 12, 2023

Could we get a status update on this? I want to upgrade to Django 5, but I can't because of the incompatibility with django-celery-beat latest.

@ddoroshev
Copy link

image

tox.ini Outdated
@@ -72,7 +74,7 @@ commands =
basepython = python3.9
usedevelop = true
commands =
pip install -U https://github.com/celery/celery/zipball/master#egg=celery
pip install -U https://github.com/celery/kombu/zipball/master#egg=kombu
pip install --upgrade https://github.com/celery/celery/zipball/master#egg=celery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install --upgrade https://github.com/celery/celery/zipball/master#egg=celery
pip install --upgrade https://github.com/celery/celery/zipball/main#egg=celery

tox.ini Outdated Show resolved Hide resolved
@cclauss cclauss requested a review from auvipy December 13, 2023 20:45
@cclauss cclauss changed the title Upgrade GitHub Actions and PyPy3.10 and Django v5.0 Upgrade GitHub Actions and PyPy3.10 Dec 13, 2023
@cclauss cclauss changed the title Upgrade GitHub Actions and PyPy3.10 Upgrade GitHub Actions and PyPy3.10 and Django 5.0 Dec 18, 2023
@cclauss cclauss mentioned this pull request Dec 19, 2023
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the pypy failure?

@cclauss cclauss changed the title Upgrade GitHub Actions and PyPy3.10 and Django 5.0 Upgrade GitHub Actions and Django 5.0 Dec 19, 2023
@cclauss
Copy link
Contributor Author

cclauss commented Dec 19, 2023

https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#specifying-a-pypy-version

Let's land with pypy3.9 and I will do a followup PR to explore pypy3.10.

@cclauss cclauss changed the title Upgrade GitHub Actions and Django 5.0 Upgrade GitHub Actions and PyPy 3.10 and Django 5.0 Dec 19, 2023
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good decision and great job

@auvipy auvipy merged commit e0430e3 into celery:main Dec 19, 2023
9 checks passed
@cclauss cclauss deleted the patch-1 branch December 19, 2023 21:06
cclauss added a commit to cclauss/django-celery-beat that referenced this pull request Dec 19, 2023
* Upgrade GitHub Actions and PyPy

* Let's drop Django v5 on PyPy v3.10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants