Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create new slide on pauses #18

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Conversation

mfontanini
Copy link
Owner

Before this change, a <!-- pause --> would copy the contents of the slide so far, create a new slide, and continue adding content to the current slide. This meant that every pause operation would create a new slide, which has the side effect that the footer's current_slide variable changes every time you jump in between a slide's pauses.

With this change a slide is now partitioned into chunks. All slides have at least 1 chunk and every pause creates a new chunk. So this means a slide with 2 pause operations has 3 chunks: what's before the first pause, what's between the first and second, and what's after. This requires dealing with jumps between slides a little different so that you jump through chunks first and then through slides.

Fixes #16

@mfontanini mfontanini merged commit 1c5faa3 into master Oct 21, 2023
6 checks passed
@mfontanini mfontanini deleted the pause-slide-increment branch October 22, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pause increments {current_slide} value
1 participant