Don't reset ordered list number after pause #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes pauses not break the numbering in ordered lists. This is a bit convoluted because from the markdown's perspective, an ordered list with a pause in between is 2 ordered lists. So the logic to realize there was a list before the pause and that we should pick up from the last index is done when constructing the presentation.
This does not work for lists of depth > 0 (e.g. a nested ordered list) because that's not valid markdown. I don't think comrak gives enough information when parsing lists to even get around this so it probably can't be fixed.
Fixes #15