-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move parse package internally and modify Makefile #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
One question, you mention
add tools module to track golangci-lint
I didn't find this one. I saw changes in Makefile, but that's it.
Is it what you were talking about?
I thought I would see something about toolchain entry in go.mod or something like that
Any specific reason parse package was moved to internal? It's been quite helpful to write custom tools for analyzing/processing the test output. |
Trying to get this project to a Happy to move it out of |
I was experimenting with it (189a957), but at the end decided the project was way too simple so I reverted those changes and forgot to update the description. Ultimately waiting for golang/go#48429 to land to improve the story around tool deps. |
Yeah, it does come up occasionally for me. I sometimes use some other "internal" to indicate that it's not finalized, like But, yeah, I can keep using the older version if you want to clean up the parse package. |
Thanks for surfacing it, happy to move it back to the top level. There might be some fairly minor breaking changes, but my ultimate goal is to make it an off-the-shelf parsing library and nail down the returned results. |
Fix #131
This PR does a few things:
add tools module to track golangci-lint