Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config providers; always load .vscode/launch.json #1237

Merged
merged 1 commit into from
May 30, 2024

Conversation

mfussenegger
Copy link
Owner

@mfussenegger mfussenegger commented May 30, 2024

  • Introduces a dap.providers.configs table which plugins can extend to
    add additional sources for dynamic configuration generation

  • Implements the two built-in configuration sources as providers

  • .vscode/launch.json files are now loaded automatically by one of
    these providers. The entries from the file always display even if the
    type doesn't match the current filetype. This gets rid of the
    type_to_filetypes mapping requirements.

Closes:

- Introduces a dap.providers.configs table which plugins can extend to
  add additional sources for dynamic configuration generation

- Implements the two built-in configuration sources as providers

- `.vscode/launch.json` files are now loaded automatically by one of
  these providers. The entries from the file always display even if the
  type doesn't match the current filetype. This gets rid of the
  `type_to_filetypes` mapping requirements.
@mfussenegger mfussenegger merged commit 54f891a into master May 30, 2024
16 checks passed
@mfussenegger mfussenegger deleted the config-providers branch May 30, 2024 13:46
mfussenegger added a commit to mfussenegger/nvim-jdtls that referenced this pull request May 30, 2024
@mfussenegger
Copy link
Owner Author

I should add that the naming is not final and might change before the next release without warning

mfussenegger added a commit to mfussenegger/nvim-jdtls that referenced this pull request Jun 6, 2024
mfussenegger added a commit to mfussenegger/nvim-jdtls that referenced this pull request Jun 6, 2024
folke pushed a commit to LazyVim/LazyVim that referenced this pull request Oct 23, 2024
## Description

The explicit call to `load_launchjs` is unnecessary, since after
mfussenegger/nvim-dap#1237 `.vscode/launch.json`
files are loaded automatically.

## Related Issue(s)
Fixes #4432


## Screenshots

<!-- Add screenshots of the changes if applicable. -->

## Checklist

- [x] I've read the
[CONTRIBUTING](https://github.com/LazyVim/LazyVim/blob/main/CONTRIBUTING.md)
guidelines.
wrightbradley added a commit to wrightbradley/nvim that referenced this pull request Nov 8, 2024
The explicit call to `load_launchjs` is unnecessary, since after
mfussenegger/nvim-dap#1237 `.vscode/launch.json`
files are loaded automatically.

Signed-off-by: wrightbradley <bradley.wright.tech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant