Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ${input:} placeholders with unknown types are left untouched #1249

Merged
merged 1 commit into from
Jun 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions spec/ext_vscode_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -364,4 +364,36 @@ describe('dap.ext.vscode', function()
assert.are.same("Your input: ", prompt)
assert.are.same("", default)
end)

it('keeps unsupported input types as is', function()
local jsonstr = [[
{
"configurations": [
{
"type": "dummy",
"request": "launch",
"name": "Dummy",
"program": "${input:myCommand}"
}
],
"inputs": [
{
"id": "myCommand",
"type": "command",
"command": "shellCommand.execute"
}
]
}
]]
local configs = vscode._load_json(jsonstr)
local ok = false
local result
coroutine.wrap(function()
local conf = configs[1]()
result = conf.program
ok = true
end)()
vim.wait(1000, function() return ok end)
assert.are.same("${input:myCommand}", result)
end)
end)
Loading