Issue 207

[marijarin]

Closes #207

[marijarin]

I had to suppress some spot bugs warnings, is it OK? If not, could you, please, give me a hint, how to meet the requirements?
Especially for EI_EXPOSE_REP2

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (f2dd83e) to head (b8dff99).
Report is 20 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #269      +/-   ##
============================================
+ Coverage     98.22%   98.48%   +0.25%     
- Complexity       55       70      +15     
============================================
  Files            19       24       +5     
  Lines           169      198      +29     
  Branches          3        5       +2     
============================================
+ Hits            166      195      +29     
  Misses            2        2              
  Partials          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[mfvanek]

I had to suppress some spot bugs warnings, is it OK? If not, could you, please, give me a hint, how to meet the requirements? Especially for EI_EXPOSE_REP2

Use https://github.com/mfvanek/pg-index-health-demo/blob/master/config/spotbugs/exclude.xml
Fully suppress EI_EXPOSE_REP2 here

pg-index-health-demo/config/spotbugs/exclude.xml

Line 4 in 559bc76

<Bug pattern="EI_EXPOSE_REP,RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE,SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE,BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>

[marijarin]

I have another question.
When running tests I noticed generated migrations be duplicated (1st and 2nd):

copied from logs

Generated migrations: [create index concurrently if not exists order_item_order_id_idx
    on demo.order_item (order_id);, create index concurrently if not exists order_item_order_id_idx
    on demo.order_item (order_id);, create index concurrently if not exists order_item_warehouse_id_idx
    on demo.order_item (warehouse_id);, create index concurrently if not exists orders_buyer_id_idx
    on demo.orders (buyer_id);, create index concurrently if not exists payment_order_id_without_nulls_idx
    on demo.payment (order_id) where order_id is not null;]

Is it OK?

[mfvanek]

I have another question. When running tests I noticed generated migrations be duplicated (1st and 2nd):

copied from logs

Generated migrations: [create index concurrently if not exists order_item_order_id_idx
    on demo.order_item (order_id);, create index concurrently if not exists order_item_order_id_idx
    on demo.order_item (order_id);, create index concurrently if not exists order_item_warehouse_id_idx
    on demo.order_item (warehouse_id);, create index concurrently if not exists orders_buyer_id_idx
    on demo.orders (buyer_id);, create index concurrently if not exists payment_order_id_without_nulls_idx
    on demo.payment (order_id) where order_id is not null;]

Is it OK?

@marijarin
Yes, it's OK because we have duplicated foreign keys

update. I've created an issue mfvanek/pg-index-health#497

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud