Wrong detection of serial types on columns with multiple constraints #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 682 682
===========================================
Files 108 108
Lines 1460 1460
Branches 113 113
===========================================
Hits 1460 1460 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kudos, SonarCloud Quality Gate passed!
|
mfvanek
deleted the
bugfix/wrong-detection-when-several-constraints-exist
branch
Evreke
pushed a commit
that referenced
this pull request
Sep 30, 2022
…179) * Updated sql query * Added test to cover the issue Co-authored-by: Ivan Vakhrushev <i.vakhrushev@banki.ru>
mfvanek
added a commit
that referenced
this pull request
Oct 16, 2022
* Background primary determiner #121 feat: reference change for connection to primary node by background task fix: cluster container names must be unique, so they are generated using the uuid Signed-off-by: Antipin Alexey <evreke@gmail.com> * Feature/generate migration to remove serial types (#172) * DbMigrationGenerator was made generic * Added ColumnWithSerialTypeMigrationGenerator * Added tests * Updated deps * Fixed code smells Co-authored-by: Ivan Vakhrushev <i.vakhrushev@banki.ru> * Signing via GPG 2+ (#173) Co-authored-by: Ivan Vakhrushev <mfvanek@gmail.com> * Making abstract classes package private (#174) * Making abstract classes package private * Fixed code smell Co-authored-by: Ivan Vakhrushev <i.vakhrushev@banki.ru> * Release v0.6.2 (#175) Co-authored-by: Ivan Vakhrushev <i.vakhrushev@banki.ru> * Prepare for the next development iteration (#176) Co-authored-by: Ivan Vakhrushev <i.vakhrushev@banki.ru> * Wrong detection of serial types on columns with multiple constraints (#179) * Updated sql query * Added test to cover the issue Co-authored-by: Ivan Vakhrushev <i.vakhrushev@banki.ru> * Bump Gradle and dependencies (#180) Co-authored-by: Ivan Vakhrushev <mfvanek@gmail.com> * Prepare for the next development iteration (#181) Co-authored-by: Ivan Vakhrushev <mfvanek@gmail.com> * Background primary determiner #121 change: resolve comments Signed-off-by: Antipin Alexey <evreke@gmail.com> * Background primary determiner #121 change: resolve comments Signed-off-by: Antipin Alexey <evreke@gmail.com> * 1) Spotbugs exclusions moved to config. We do not dirty the code with SuppressFBWarnings. 2) Added javadoc to HighAvailabilityPgConnectionImpl 3) Refactored construction methods in HighAvailabilityPgConnectionImpl. 4) Mocked tests moved to HighAvailabilityPgConnectionUnitTest with "fast" tag. 5) ClusterAwareTestBase renamed to PgConnectionAwareCluster 6) Implemented AutoCloseable for all Testcontainers wrappers. 6) Migrated tests to try-with-resources. * Fixed build on MacOS * Fixed code smell * Fixed build on Windows 11 Signed-off-by: Antipin Alexey <evreke@gmail.com> Co-authored-by: Ivan Vakhrushev <37612014+mfvanek@users.noreply.github.com> Co-authored-by: Ivan Vakhrushev <i.vakhrushev@banki.ru> Co-authored-by: Ivan Vakhrushev <mfvanek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177