Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #188: nunmap only if mapping exists #250

Merged
merged 2 commits into from
Oct 26, 2023
Merged

fix #188: nunmap only if mapping exists #250

merged 2 commits into from
Oct 26, 2023

Conversation

kbwo
Copy link
Contributor

@kbwo kbwo commented Oct 25, 2023 •
edited
Loading

Thank you for the great extension. I love this.
I fixed #188, preventing from calling nunmap if the mapping doesn't exist.

@kbwo kbwo marked this pull request as draft October 25, 2023 15:56
@kbwo kbwo force-pushed the fix/nunmap-error branch from c395c46 to b295c98 Compare October 25, 2023 15:59
@mg979
Copy link
Owner

mg979 commented Oct 25, 2023

Better to use silent!.

@kbwo
Copy link
Contributor Author

kbwo commented Oct 25, 2023

@mg979 Thanks for your quick reply. I've changed it.

@kbwo kbwo marked this pull request as ready for review October 25, 2023 23:50
@kbwo kbwo force-pushed the fix/nunmap-error branch from 7c01cf7 to 9151383 Compare October 26, 2023 00:36
@mg979 mg979 changed the title fix #188: nunmap if only mapping exists fix #188: nunmap only if mapping exists Oct 26, 2023
@mg979 mg979 merged commit aec289a into mg979:master Oct 26, 2023
@mg979
Copy link
Owner

mg979 commented Oct 26, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] if change surround keymap, bug will occur
2 participants
@kbwo @mg979