[FieldValueSelectionFilter] [i18n] Let EuiSelectable handle default…

… loading and empty messages (elastic#7718)
mgadewoll · May 3, 2024 · 930a6d8 · 930a6d8
1 parent db65bc7
commit 930a6d8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/changelogs/upcoming/7718.md b/changelogs/upcoming/7718.md
@@ -0,0 +1,4 @@
+**Bug fixes**
+
+- Fixed i18n of empty and loading state messages for the `FieldValueSelectionFilter` component
+
diff --git a/src/components/search_bar/filters/field_value_selection_filter.tsx b/src/components/search_bar/filters/field_value_selection_filter.tsx
@@ -66,8 +66,6 @@ const defaults = {
   config: {
     multiSelect: true,
     filterWith: 'prefix',
-    loadingMessage: 'Loading...',
-    noOptionsMessage: 'No options found',
     searchThreshold: 10,
   },
 };
@@ -400,16 +398,10 @@ export class FieldValueSelectionFilter extends Component<
               options={items}
               renderOption={(option) => option.view}
               isLoading={isNil(this.state.options)}
-              loadingMessage={
-                config.loadingMessage || defaults.config.loadingMessage
-              }
-              emptyMessage={
-                config.noOptionsMessage || defaults.config.noOptionsMessage
-              }
+              loadingMessage={config.loadingMessage}
+              emptyMessage={config.noOptionsMessage}
               errorMessage={this.state.error}
-              noMatchesMessage={
-                config.noOptionsMessage || defaults.config.noOptionsMessage
-              }
+              noMatchesMessage={config.noOptionsMessage}
               listProps={{
                 isVirtualized: isOverSearchThreshold || false,
               }}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		Bug fixes

		- Fixed i18n of empty and loading state messages for the `FieldValueSelectionFilter` component