Added option to allow custom CSS properties (variables). #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an option to allow custom CSS properties (variables) without specifying all the potential options (ie, allow all
--*
css properties)I ran into an issue where I wanted to accept CSS variables, but based on the execution order, it would leave the value part unsanitized. The
SanitizeStyleDeclaration
would reject the name immediately, and while it can be cancelled in theOnRemovingStyle
event, that leaves the value part unevaluated.With this update, evaluation of the property name can be customized by overriding the
IsAllowedCssProperty
method. The default handling checks theAllowedCssProperties
, same as before. Then if theAllowCssCustomProperties
flag is true, it will allow any property beginning with--
. This method can be override if developers want to refine the prefix.It allows css variables both in
<style>
tags (if allowed) as well as tagstyle
attributes (<div style="--my-var:1px"></div>
)The flag can be set like this: