Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File dialog: new folder: can't set name when the folder is empty. #44

Closed
FabuGrammer opened this issue Oct 7, 2013 · 9 comments
Closed
Assignees

Comments

@FabuGrammer
Copy link

Using the file dialog.

If you try to create a new folder in an empty folder using the new folder button in the toolbar, new new folder is created with the name "New folder" and there is no way to edit it.

Normally (when the folder is not empty) the new folder appear in name edition mode so you can set the name before it is actually created.

There is no workaround as when you right click the folder there is no menu to allow renaming (there is no pop up menu at all). Also, as soon as you enable weblab as the look and feel you get the weblaf file dialog even if you use the swing file dialog instead of the web file dialog.

Correction, if I type letters even though there is no folder name edition box and press enter, the name of the folder is set properly. The editor is just not visible, that's the issue.

@ghost ghost assigned mgarin Oct 7, 2013
@mgarin
Copy link
Owner

mgarin commented Oct 7, 2013

Thanks for reporting!
I will investigate this issue and include a fix into v1.23 release tomorrow.

@FabuGrammer
Copy link
Author

Thanks.
By the way I'm Ghyz on the forum.
This is my GitHub nic. :)

@mgarin
Copy link
Owner

mgarin commented Oct 7, 2013

I see. By the way, you could also post questions and feature request here instead of forum - easier to track and discuss. There are "enhancement" and "question" labels for that case :)

@mgarin
Copy link
Owner

mgarin commented Oct 8, 2013

I tried to reproduce but everything works fine for me - whether i create new folder inside an empty folder or somewhere where there are files already.

I guess this might be system-specific or JDK-specific issue, so could you say which JDK/OS you are using?

@mgarin
Copy link
Owner

mgarin commented Oct 8, 2013

I was not able to reproduce your bug, but it might be somehow connected to the one i found a few minutes ago while checking the file chooser new folder creation:
image
That occurs when you enter an empty folder, switch view (tiles->icons or icons->tiles) and try to create new folder. This should be some kind of an update bug, i will fix it now but it might not affect the issue you have described...

mgarin added a commit that referenced this issue Oct 8, 2013
#44 - Incorrect editor appearance in some rare cases fixed
WebFileChooserPanel.java orientation change fixes
WebFileChooserPanel.java view focus loss on view type change fixed
Debug information is now stored within binaries
Bytes translation fix
@mgarin
Copy link
Owner

mgarin commented Oct 8, 2013

I have fixed the issue i described above - check whether your issue is still present in v1.23 release or not:
https://github.com/mgarin/weblaf/releases/tag/v1.23

@mgarin
Copy link
Owner

mgarin commented Oct 15, 2013

It seems that it was fixed with v1.23 update.
If you still have this problem - just report back and i will reopen the issue.

@mgarin mgarin closed this as completed Oct 15, 2013
@FabuGrammer
Copy link
Author

The initial problem is gone.
However there is a new one introduced by the fix (or something else in 1.24).
When you set the initial folder to an empty folder: fileChooser.setSelectedFile(anEmptyFolder), then the dialog box is wrongly sized when you call showOpenDialog. Please see the picture.
image

@mgarin
Copy link
Owner

mgarin commented Oct 23, 2013

There is indeed an issue with empty folder, thanks for pointing it out :)
Fix will be available in next update.
Here is a separate issue you might want to track: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants