fix: ignore re-defined variables

Fix #220
mgechev · May 8, 2017 · 61f9fe9 · 61f9fe9
1 parent 0fcdcd1
commit 61f9fe9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/templatesUsePublicRule.ts b/src/templatesUsePublicRule.ts
@@ -34,6 +34,11 @@ class SymbolAccessValidator extends RecursiveAngularExpressionVisitor {
       }
       ast = <e.PropertyRead>receiver;
     }
+    // We have the variable re-declared in the template
+    // which makes it automatically public.
+    if (this.preDefinedVariables[ast.name]) {
+      return;
+    }
     const allMembers = getDeclaredMethods(this.context.controller).concat(getDeclaredProperties(this.context.controller));
     const member = allMembers.filter((m: any) => m.name && m.name.text === ast.name).pop();
     if (member) {

diff --git a/test/templatesUsePublicRule.spec.ts b/test/templatesUsePublicRule.spec.ts
@@ -180,7 +180,6 @@ describe('templates-use-public', () => {
         assertSuccess('templates-use-public', source);
     });
 
-
     it('should succeed on public nested props', () => {
       let source = `
         @Component({
@@ -192,5 +191,21 @@ describe('templates-use-public', () => {
         }`;
         assertSuccess('templates-use-public', source);
     });
+
+    it.only('should succeed shadowed variable', () => {
+      let source = `
+        @Component({
+          selector: 'foobar',
+          template: \`
+            <div *ngFor="let smile of smile">
+              <smile-cmp [smile]="smile"></smile-cmp>
+            </div>
+          \`
+        })
+        class Test {
+          smile: any;
+        }`;
+      assertSuccess('templates-use-public', source);
+    });
   });
 });