Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component-selector-prefix should match first word of selector instead of prefix #103

Closed
chrisse27 opened this issue Oct 1, 2016 · 1 comment
Assignees
Labels

Comments

@chrisse27
Copy link

If I have the component-selector-prefix rule configured such that the prefix is set to "app" then the rule still allows me to use "apps-my-component" as selector.

I think it would be better if the component-selector-prefix rule would match the first word of the selector against the configured prefix. The scanning algorithm to find the first word should depend on the configured value for the "component-selector-name" rule.

Alternatively, a new rule called component-selector-first-word rule should be introduced that implements the described behavior.

@mgechev
Copy link
Owner

mgechev commented Oct 11, 2016

Yes, we'll make a lot of improvements in near future (next release) here are some more details #15.

@mgechev mgechev added the P2 label Oct 11, 2016
@mgechev mgechev added this to the Beta 2 - Trichocolea mollissima milestone Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants