Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pipe class has the Pipe decorator, so it should implement the PipeTransform interface #142

Closed
antonybudianto opened this issue Nov 9, 2016 · 4 comments

Comments

@antonybudianto
Copy link

Hi,

I'm upgrading to TypeScript 2.0.8, and then one rule breaks that told my pipe has the Pipe decorator (yes, it does), and should implement the PipeTransform interface (already does)

It didn't happen in 2.0.7.

Thank you

@mgechev
Copy link
Owner

mgechev commented Nov 9, 2016

Would you share a code snippet? Using TypeScript 2.0.8 all the tests are passing for me.

@antonybudianto
Copy link
Author

antonybudianto commented Nov 9, 2016

https://github.com/antonybudianto/angular-webpack-starter

  • update the typescript
  • run npm run lint

@antonybudianto
Copy link
Author

Full error log

npm ERR! Darwin 16.1.0
npm ERR! argv "/Users/antony/.nvm/versions/node/v7.0.0/bin/node" "/Users/antony/.nvm/versions/node/v7.0.0/bin/npm" "run" "tslint" "src/**/*.ts"
npm ERR! node v7.0.0
npm ERR! npm  v3.10.9
npm ERR! code ELIFECYCLE
npm ERR! angular-webpack-starter@2.0.0-beta.2 tslint: `tslint "src/**/*.ts"`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the angular-webpack-starter@2.0.0-beta.2 tslint script 'tslint "src/**/*.ts"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-webpack-starter package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tslint "src/**/*.ts"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-webpack-starter
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-webpack-starter
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/antony/Documents/Code/Web/angular-webpack-starter/npm-debug.log

npm ERR! Darwin 16.1.0
npm ERR! argv "/Users/antony/.nvm/versions/node/v7.0.0/bin/node" "/Users/antony/.nvm/versions/node/v7.0.0/bin/npm" "run" "lint"
npm ERR! node v7.0.0
npm ERR! npm  v3.10.9
npm ERR! code ELIFECYCLE
npm ERR! angular-webpack-starter@2.0.0-beta.2 lint: `npm run tslint "src/**/*.ts"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the angular-webpack-starter@2.0.0-beta.2 lint script 'npm run tslint "src/**/*.ts"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-webpack-starter package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run tslint "src/**/*.ts"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-webpack-starter
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-webpack-starter
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/antony/Documents/Code/Web/angular-webpack-starter/npm-debug.log

@mgechev
Copy link
Owner

mgechev commented Nov 13, 2016

It seems problem related to TypeScript 2.1. Fixed by d49cc26. Should be on npm by the end of next week.

@mgechev mgechev closed this as completed Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants