-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this codelyzer check seems broken for pipes #145
Comments
I have the following code: import { Component, PipeTransform, Pipe } from '@angular/core';
import { Config } from './shared/index';
import './operators';
@Pipe({name: 'orderByActive'})
export class OrderByActivePipe implements PipeTransform {
transform() {
return true;
}
} It works fine for me. Can you reproduce the issue on http://codelyzer.com? |
@mgechev i put it in codelyzer and it says no issue... however the same error is occuring.... src/app/components/admin/person/order-by-active.pipe.ts[4, 1]: The OrderByActivePipe class has the Pipe decorator, so it should implement the PipeTransform interface |
looks like #142 |
npm will install typescript 2.1.x codelyzer/src/util/syntaxKind.ts > SyntaxKind.current().ImplementsKeyword returns 106 where it should be 107 starting from TypeScript version 2.1.0 The breaking change is here: microsoft/TypeScript@6814c1d#diff-9a9b25e2950a3c3c611c9e2e095e2e41 before: ImplementsKeyword = 106 |
@mgechev just to ask what is the latest version? I don't see releases... thanks by the way |
The latest version is
|
when using this command
"use-pipe-transform-interface": false, // what is this -- seems to be broken
it always fails and the code seems correct
The text was updated successfully, but these errors were encountered: