Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on strict TS compilation mode #629

Closed
rkirov opened this issue May 16, 2018 · 4 comments
Closed

Turn on strict TS compilation mode #629

rkirov opened this issue May 16, 2018 · 4 comments
Labels
enhancement
Milestone
4.4.0 - Ken Thompson

Comments

@rkirov
Copy link

rkirov commented May 16, 2018

We started syncing this repo for google internal usage. Technically we have exceptions for code that doesn't have 'strict': true, but it is generally best to use that flag to be consistent with the rest of google TS users.
@rafaelss95
Copy link
Collaborator

rafaelss95 commented May 16, 2018 •
edited
Loading

I was about to open an issue to suggest the same thing.

@mgechev can I work on it?

@mgechev
Copy link
Owner

mgechev commented May 16, 2018

@rafaelss95 sure!

@mgechev
Copy link
Owner

mgechev commented May 21, 2018

@rafaelss95 how's this task going?

@rafaelss95
Copy link
Collaborator

@mgechev Sry for the delay, I'm a little busy this week, but I hope I can send a PR tomorrow. 🚀

@rafaelss95 rafaelss95 mentioned this issue May 26, 2018
Merged
@mgechev mgechev added this to the 4.4.0 - Ken Thompson milestone Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4.0 - Ken Thompson
Development

No branches or pull requests
3 participants
@rkirov @mgechev @rafaelss95