chore: enable strict #631
Merged
chore: enable strict #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgechev
reviewed
May 26, 2018
tsconfig.json
Outdated
| @@ -8,6 +8,8 @@ | |||
| "noLib": false, | |||
| "outDir": "./dist", | |||
| "removeComments": true, | |||
| "strict": true, | |||
| "strictPropertyInitialization": false, | |||
There was a problem hiding this comment.
@rkirov does it work for you if we disable strictPropertyInitialization?
There was a problem hiding this comment.
@mgechev There are only few some places that forced me to disable this. I can enable this and initialize properties properly or even use a ! to indicate that I want hack that property. Let me know what should I do.
There was a problem hiding this comment.
If the job isn't too hard, I would prefer to use the default value of strictPropertyInitialization. Could you update this PR in this direction ?
There was a problem hiding this comment.
@wKoza Updated.
|
@rafaelss95 great job! LGTM, I'll let @wKoza to have a look as well. |
|
Thanks, @mgechev :) |
|
Ping @wKoza. |
wKoza
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #629.