Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-inline-decorator is missing in v4.4 #670

Closed
chrisguttandin opened this issue Jun 23, 2018 · 2 comments
Closed

prefer-inline-decorator is missing in v4.4 #670

chrisguttandin opened this issue Jun 23, 2018 · 2 comments

Comments

@chrisguttandin
Copy link

Hi @mgechev, I think the prefer-inline-decorator rule somehow got lost when releasing v4.4. The 'preferInlineDecoratorRule.ts' file is not part of the package and tslint does also complain that it can't find the rule.

Could not find implementations for the following rules specified in the configuration:
    prefer-inline-decorator
Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.
mgechev added a commit that referenced this issue Jun 23, 2018
@mgechev
fix: regressions in 4.4.0
c68b0f7 
- Downgrade to TypeScript 2.7 which is the officially supported on by `@angular/core`
- Export `preferInlineDecoratorRule`

We should introduce a public API guard to make sure we don't hit
regressions like the second one.

Fix #669 #670
mgechev added a commit that referenced this issue Jun 23, 2018
@mgechev
fix: regressions in 4.4.0
2f23d77 
- Downgrade to TypeScript 2.7 which is the officially supported on by `@angular/core`
- Export `preferInlineDecoratorRule`

We should introduce a public API guard to make sure we don't hit
regressions like the second one.

Fix #669 #670
@mgechev mgechev mentioned this issue Jun 23, 2018
Merged
mgechev added a commit that referenced this issue Jun 24, 2018
@mgechev
fix: regressions in 4.4.0 (#671)
d922dcb 
* fix: regressions in 4.4.0

- Downgrade to TypeScript 2.7 which is the officially supported on by `@angular/core`
- Export `preferInlineDecoratorRule`

We should introduce a public API guard to make sure we don't hit
regressions like the second one.

Fix #669 #670

* refactor: address comments

* fix: regression in selector type
@mgechev mgechev closed this as completed Jun 24, 2018
@mgechev
Copy link
Owner

mgechev commented Jun 24, 2018

Fixed in 4.4.1.

@chrisguttandin
Copy link
Author

thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisguttandin @mgechev