Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors not being displayed in the correct files #700

Merged
merged 1 commit into from
Aug 13, 2018
Merged

fix: errors not being displayed in the correct files #700

merged 1 commit into from
Aug 13, 2018

Conversation

rafaelss95
Copy link
Collaborator

Fixes #692 #699.

It was a regression caused by PR #587. I'm not sure how we can add tests to prevent errors like this from popping up.

Copy link
Owner

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@mgechev mgechev merged commit db3cf5a into mgechev:master Aug 13, 2018
@rafaelss95 rafaelss95 deleted the fix-regression-deprecation branch August 13, 2018 04:26
@jaufgang
Copy link

Thank you @rafaelss95 for fixing this.

@mgechev, could you please publish a new release ASAP with this fix merged in? The bug is actually mangling code, so getting a new release out quickly will help prevent other developers from the ensuing headaches of encountering this bug. Thanks!

@mayfieldiv
Copy link

Glad to see this will be in the next release. I updated my dependencies today to find the linter mangling TS files as others mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants