refactor: replace/remove deprecated method calls #587

rafaelss95 · 2018-04-29T02:14:38Z

This:

Adds deprecation rule to the tslint.json;
Replaces all usages of deprecated methods (in majority tslint methods);

rafaelss95 · 2018-04-29T02:17:56Z

@mgechev There are two leftovers that I was not able to change because definitely broke some tests:

1st.:

codelyzer/src/angular/templates/basicTemplateAstVisitor.ts

Lines 182 to 187 in d4bf62d

    
           protected visitNgTemplateAST(ast: e.AST, templateStart: number, prop?: any) { 
        
             const templateVisitor = new this.expressionVisitorCtrl(this.getSourceFile(), this._originalOptions, this.context, templateStart); 
        
             templateVisitor.preDefinedVariables = this._variables; 
        
             templateVisitor.parentAST = prop; 
        
             templateVisitor.visit(ast); 
        
             templateVisitor.getFailures().forEach(f => this.addFailure(f));

Changing this:

templateVisitor.getFailures().forEach(f => this.addFailure(f));

to:

templateVisitor.getFailures().forEach(f => this.addFailureFromStartToEnd(f.getStartPosition().getPosition(), f.getEndPosition().getPosition(), f.getFailure(), f.getFix()));

... broke 16 tests.

2nd.:

codelyzer/src/angular/sourceMappingVisitor.ts

Lines 105 to 108 in d4bf62d

    
           createFailure(s: number, l: number, message: string, fix?: Fix): RuleFailure { 
        
             const { start, length } = this.getMappedInterval(s, l); 
        
             return super.createFailure(start, length, message, fix); 
        
           }

Remove this deprecate call broke 66 tests.

Could you give me a hand on that?

rafaelss95 · 2018-04-29T23:16:16Z

src/useLifeCycleInterfaceRule.ts

    methods.forEach(m => {
-      let n = (<any>m.name).text;
-      if (n && this.isMethodValidHook(m, interfaces)) {
-        let hookName = n.substr(2, n.lenght);


Fun fact: lengHt was mispelled (2 times in this class) :)

mgechev · 2018-05-02T02:14:18Z

@rafaelss95 thanks for the cleanup! Would you check why the build is failing?

rafaelss95 · 2018-05-02T02:29:32Z

@mgechev so... that was what I asked above, if I change in these 2 places I mentioned, the tests break, I really don't know why.

mgechev · 2018-05-02T02:35:10Z

ERROR: /Users/travis/build/mgechev/codelyzer/src/angular/sourceMappingVisitor.ts[107, 18]: createFailure is deprecated: Prefer `addFailureAt` and its variants.
ERROR: /Users/travis/build/mgechev/codelyzer/src/angular/templates/basicTemplateAstVisitor.ts[186, 53]: addFailure is deprecated: Prefer `addFailureAt` and its variants.

I guess we should not use deprecated methods.

rafaelss95 · 2018-05-02T02:36:51Z

I think you don't understand what I mean. I'm trying to say that if I change these leftovers deprecated calls it break some tests. See #587 (comment)

rafaelss95 · 2018-05-02T04:48:02Z

@mgechev I've pushed the changes for those leftovers. Now you can see the full log error in travis.

rafaelss95 · 2018-05-12T21:24:36Z

@mgechev After many unsuccessful attempts trying to replace the two problematic places, I think the best choice for now is to disable the rule for 2 calls:

That said, this PR is ready for review.

rafaelss95 · 2018-05-16T22:49:40Z

bump @mgechev.

mgechev · 2018-05-16T23:01:55Z

@rafaelss95 will take a look in a few minutes.

mgechev · 2018-05-16T23:30:58Z

package.json

@@ -8,7 +8,7 @@
    "format:base": "prettier --config ./.prettierrc \"*.{json,md}\" \"src/**/*.{css,scss,ts}\" \"test/**/*.{css,scss,ts}\"",
    "format:check": "npm run format:base -- --list-different",
    "format:fix": "npm run format:base -- --write",
-    "lint": "tslint -c tslint.json \"src/**/*.ts\" \"test/**/*.ts\"",
+    "lint": "tslint -p . -c tslint.json \"src/**/*.ts\" \"test/**/*.ts\"",


Do we need -p? Are we using any rules with type checking?

I see that's required because of the deprecation rule?

Yes, deprecation rule requires type information.

mgechev · 2018-05-16T23:31:36Z

src/angular/sourceMappingVisitor.ts

@@ -104,6 +104,7 @@ export class SourceMappingVisitor extends RuleWalker {

  createFailure(s: number, l: number, message: string, fix?: Fix): RuleFailure {
    const { start, length } = this.getMappedInterval(s, l);
+    // tslint:disable-next-line:deprecation
    return super.createFailure(start, length, message, fix);


createFailure is deprecated?

Yep, it has been deprecated for over an year. PR palantir/tslint#1952

mgechev · 2018-05-16T23:36:10Z

src/templatesNoNegatedAsyncRule.ts

@@ -16,39 +16,41 @@ class TemplateToNgTemplateVisitor extends RecursiveAngularExpressionVisitor {
      return super.visitBinary(expr, context);
    }

-    const operator = this.codeWithMap.code.slice(expr.left.span.end, expr.right.span.start);
+    const {


Let's use less of these assignments. A bit hard to follow :-)

mgechev

Good job! LGTM.

rafaelss95 changed the title ~~refactor: replace/remove deprecation method calls~~ refactor: replace/remove deprecated method calls Apr 29, 2018

rafaelss95 commented Apr 29, 2018

View reviewed changes

refactor: replace/remove deprecated method calls

8a9eceb

mgechev reviewed May 16, 2018

View reviewed changes

mgechev approved these changes May 16, 2018

View reviewed changes

mgechev merged commit 04f99af into mgechev:master May 16, 2018

rafaelss95 deleted the refactor-remove-deprecation-calls branch May 16, 2018 23:40

robzenn92 mentioned this pull request Jun 27, 2018

Property length misspelled twice in useLifeCycleInterfaceRule.js #681

Closed

rafaelss95 mentioned this pull request Aug 13, 2018

fix: errors not being displayed in the correct files #700

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: replace/remove deprecated method calls #587

refactor: replace/remove deprecated method calls #587

rafaelss95 commented Apr 29, 2018 •

edited

Loading

rafaelss95 commented Apr 29, 2018 •

edited

Loading

rafaelss95 Apr 29, 2018

mgechev May 2, 2018

mgechev commented May 2, 2018

rafaelss95 commented May 2, 2018

mgechev commented May 2, 2018

rafaelss95 commented May 2, 2018 •

edited

Loading

rafaelss95 commented May 2, 2018

rafaelss95 commented May 12, 2018

rafaelss95 commented May 16, 2018

mgechev commented May 16, 2018

mgechev May 16, 2018

mgechev May 16, 2018

rafaelss95 May 16, 2018

mgechev May 16, 2018

rafaelss95 May 16, 2018 •

edited

Loading

mgechev May 16, 2018

mgechev left a comment

refactor: replace/remove deprecated method calls #587

refactor: replace/remove deprecated method calls #587

Conversation

rafaelss95 commented Apr 29, 2018 • edited Loading

rafaelss95 commented Apr 29, 2018 • edited Loading

rafaelss95 Apr 29, 2018

Choose a reason for hiding this comment

mgechev May 2, 2018

Choose a reason for hiding this comment

mgechev commented May 2, 2018

rafaelss95 commented May 2, 2018

mgechev commented May 2, 2018

rafaelss95 commented May 2, 2018 • edited Loading

rafaelss95 commented May 2, 2018

rafaelss95 commented May 12, 2018

rafaelss95 commented May 16, 2018

mgechev commented May 16, 2018

mgechev May 16, 2018

Choose a reason for hiding this comment

mgechev May 16, 2018

Choose a reason for hiding this comment

rafaelss95 May 16, 2018

Choose a reason for hiding this comment

mgechev May 16, 2018

Choose a reason for hiding this comment

rafaelss95 May 16, 2018 • edited Loading

Choose a reason for hiding this comment

mgechev May 16, 2018

Choose a reason for hiding this comment

mgechev left a comment

Choose a reason for hiding this comment

rafaelss95 commented Apr 29, 2018 •

edited

Loading

rafaelss95 commented Apr 29, 2018 •

edited

Loading

rafaelss95 commented May 2, 2018 •

edited

Loading

rafaelss95 May 16, 2018 •

edited

Loading