Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom fatal error from app-root-path #177

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Atom fatal error from app-root-path #177

merged 1 commit into from
Dec 6, 2016

Conversation

scttcper
Copy link
Contributor

@scttcper scttcper commented Dec 5, 2016

In Atom Editor when using linter-tslint and codelyzer 2.0.0-beta.1 we're unable to lint files currently because app-root-path fails. I'm not sure why? But putting it inside the try catch to fail silently stops it from being broken.

@scttcper scttcper changed the title make require app-root-path fail silently Atom fatal error from app-root-path Dec 5, 2016
@mgechev
Copy link
Owner

mgechev commented Dec 6, 2016

Thanks for the PR! I'll include it as part of beta.2, which should be released in the next week or two.

@mgechev mgechev merged commit c1b91ed into mgechev:master Dec 6, 2016
@mgechev mgechev self-assigned this Dec 6, 2016
@mgechev mgechev added this to the 2.0.0-Beta 2 - Turing switch milestone Dec 6, 2016
@scttcper scttcper deleted the fix-atom branch December 6, 2016 16:11
@mgechev mgechev mentioned this pull request Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants