feat: add a no-negated-async rule #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular's async pipes emit `null` initially, prior to the observable emitting any values, or the promise resolving. This can cause negations, like `*ngIf="!(myConditional | async)"` to thrash the layout and cause expensive side-effects like firing off XHR requests for a component which should not be shown. This PR adds a linting rule which fails on usages of !(expr | async) and (expr | async) == false.
connor4312
force-pushed
the
no-negated-async
branch
from
c8d3491
to
9276e7c
Compare
|
It looks like the failing build is an issue with node-sass on Travis' 32-bit slaves. Tests pass otherwise here! |
|
@connor4312 thanks for the PR, looks great! I will review and merge as soon as possible. Looks great, at first! |
mgechev
approved these changes
Jun 10, 2017
|
@connor4312 merged. Great job! |
|
Thank you! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular's async pipes emit
nullinitially, prior to the observable emittingany values, or the promise resolving. This can cause negations, like
*ngIf="!(myConditional | async)"to thrash the layout and cause expensiveside-effects like firing off XHR requests for a component which should not
be shown.
This PR adds a linting rule which fails on usages of !(expr | async) and
(expr | async) == false.