feat: add "banana in a box" rule #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haha, I love the error messages. Would be awesome if we're able to introduce this rule as part of the next release as well! |
mgechev
reviewed
Jun 13, 2017
src/bananaInBoxRule.ts
Outdated
|
|
||
| const getReplacements = (text: ast.BoundEventAst, absolutePosition: number) => { | ||
| const expr: string = (text.sourceSpan as any).toString(); | ||
| const internalStart = expr.indexOf('(['); |
There was a problem hiding this comment.
Let's use the constants defined above.
src/bananaInBoxRule.ts
Outdated
| import {NgWalker} from './angular/ngWalker'; | ||
|
|
||
|
|
||
| const BoxInABananaOpen = '(['; |
There was a problem hiding this comment.
Lets rename it to ValidSyntaxOpen or something similar. I'm getting confused reading BoxInABanana*, wondering if that was the valid or invalid syntax.
| templateVisitorCtrl: BananaInBoxTemplateVisitor, | ||
| })); | ||
| } | ||
| } |
src/bananaInBoxRule.ts
Outdated
| let error = null; | ||
| const expr: any = (<any>prop.sourceSpan).toString(); | ||
| if (BoxInABananaRe.test(expr)) { | ||
| error = 'The box is in a banana! Expecting Banana in a box [(expr)]'; |
There was a problem hiding this comment.
This warning message is fun but lets change it to something like: "Invalid binding syntax. Use [(expr)] instead".
There was a problem hiding this comment.
No problem ;) . Done
wKoza
changed the title
|
Thanks! Will take a look tomorrow & merge/comment. |
mgechev
approved these changes
Jun 15, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #314