fix(rule): don't check keyup events for some elements #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgechev
reviewed
Feb 22, 2019
mgechev
reviewed
Feb 22, 2019
src/util/attributesComparator.ts
Outdated
| import { getLiteralValue } from './getLiteralValue'; | ||
|
|
||
| function attributesComparator(baseAttributes: any = [], el: ElementAst): boolean { | ||
| const attributes: Array<AttrAst | BoundElementProperty> = [].concat(...(el.attrs as any), ...(el.inputs as any)); |
There was a problem hiding this comment.
I'd suggest to refactor it to use sets/maps, so we can drop the quadratic check to a linear one.
There was a problem hiding this comment.
Also, if possible, can we remove these any casts?
There was a problem hiding this comment.
@rafaelss95 done
@mgechev I have two different arrays, I don't think I can escape the quadratic check here
mgechev
reviewed
Feb 22, 2019
mgechev
reviewed
Feb 22, 2019
mgechev
reviewed
Feb 22, 2019
rafaelss95
reviewed
Feb 23, 2019
src/util/attributesComparator.ts
Outdated
| import { getLiteralValue } from './getLiteralValue'; | ||
|
|
||
| function attributesComparator(baseAttributes: any = [], el: ElementAst): boolean { | ||
| const attributes: Array<AttrAst | BoundElementProperty> = [].concat(...(el.attrs as any), ...(el.inputs as any)); |
There was a problem hiding this comment.
Also, if possible, can we remove these any casts?
mgechev
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #771