fix exported #1002 for ast.Ident

mgechev · Jun 28, 2024 · 98eabe8 · 98eabe8
1 parent 47f336c
commit 98eabe8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/rule/exported.go b/rule/exported.go
@@ -366,6 +366,9 @@ func (w *lintExported) Visit(n ast.Node) ast.Visitor {
 
 func (w *lintExported) doCheckPublicInterface(typeName string, iface *ast.InterfaceType) {
  for _, m := range iface.Methods.List {
+ if _, ok := m.Type.(*ast.Ident); ok {
+ continue
+ }
  if ast.IsExported(m.Names[0].Name) {
  w.lintInterfaceMethod(typeName, m)
  }

diff --git a/testdata/exported-issue-1002.go b/testdata/exported-issue-1002.go
@@ -6,13 +6,17 @@ package golint
 
 // Some - some interface
 type Some interface {
+ Other // should not fail
  // Correct - should do all correct
  Correct()
  // MATCH /comment on exported interface method Some.SemiCorrect should be of the form "SemiCorrect ..."/
  SemiCorrect() 
  NonCorrect() // MATCH /public interface method Some.NonCorrect should be commented/
 }
 
+// Other - just to check names compatibility
+type Other interface {}
+
 // for private interfaces it doesn't check docs anyway
 
 type somePrivate interface {