Skip to content

Commit

Permalink
Fix package check in error-strings rule (#610) (#611)
Browse files Browse the repository at this point in the history
Co-authored-by: SalvadorC <salvadorcavadini+github@gmail.com>
  • Loading branch information
doniacld and chavacava authored Oct 30, 2021
1 parent 0fada9d commit faba17a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions rule/error-strings.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ func (w lintErrorStrings) match(expr *ast.CallExpr) bool {
}
// retrieve the package
id, ok := sel.X.(*ast.Ident)
if !ok {
return false
}
functions, ok := w.errorFunctions[id.Name]
if !ok {
return false
Expand Down
4 changes: 4 additions & 0 deletions testdata/golint/error-strings.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,9 @@ func g(x int) error {
err = fmt.Errorf("Newlines are really fun\n") // MATCH /error strings should not be capitalized or end with punctuation or a newline/
err = errors.New(`too much stuff.`) // MATCH /error strings should not be capitalized or end with punctuation or a newline/
err = errors.New("This %d is too low", x) // MATCH /error strings should not be capitalized or end with punctuation or a newline/

// Non-regression test for issue #610
d.stack.Push(from)

return err
}

0 comments on commit faba17a

Please sign in to comment.