Is it possible for revive to return a non-zero exit code when there are issues and zero if not?

[inliquid]

I'd like to run revive in some sort of automated test during build. However I found that it returns zero in any case. This makes it more complicated to check result of running the tool.

[chavacava]

Hi @inliquid, in the configuration you can set errorCode and warningCode to the values you need.

For example with

# Sets the error code for failures with severity "error"
errorCode = 2
# Sets the error code for failures with severity "warning"
warningCode = 1

revive will return 2 if it found at least one error, 1 if there are no errors but at least one warning, or 0 if there are no errors nor warnings.

[mgechev]

@inliquid I'm closing the issue. Feel free to comment/open a new issue in case we misunderstood you.

[jan-xyz]

The above example overwrites also the linter configuration, so having a file with just that content also disables all the linters. Is there a way to say: "lint as usual and per default but exit 1 if there was a problem"?

[chavacava]

@jan-xyz the above example is NOT a full configuration, just the lines you need to modify in order to get error codes when the linter finds issues.

[jan-xyz]

I understand that. Before I was running revive without a config though, now by adding the exit codes I need to specify a full config, and I am curious if the list of linter default rules will change in the future and I will miss those new rules?

[chavacava]

I get your point @jan-xyz.
The default rules will not be updated, they correspond to these of golint (now frozen)
If you want to continue using revive without a configuration you can rely on some bash hacks to get an error code when failures are found.
golint finished adding a flag (set_exit_status) to return 1 if failures are found. We might consider adding this flag to revive (that is meant to be a drop-in replacement of golint)

[jan-xyz]

That would be my favorite solution 🤗 I would also offer to provide the PR for it, if you are ok with adding it

[chavacava]

I would also offer to provide the PR for it, if you are ok with adding it

PRs are welcome!

[jan-xyz]

I filed #589 , let me know what you think 🤗