Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chan struct{} triggers nested-structs error #744

Closed
Integralist opened this issue Sep 2, 2022 · 2 comments · Fixed by #746
Closed

chan struct{} triggers nested-structs error #744

Integralist opened this issue Sep 2, 2022 · 2 comments · Fixed by #746
Assignees
Labels

Comments

@Integralist
Copy link

Describe the bug
chan struct{} triggers the nested-structs error.

Expected behavior
I expected this use case to be ignored.

Desktop (please complete the following information):

  • OS: macOS Monterey
  • Version of Go: 1.19

Additional context
I'm presuming this is a false positive bug and there's no idiomatic go way to work around it (apologies if there is and I wasn't aware).

chavacava added a commit that referenced this issue Sep 3, 2022
@chavacava
Copy link
Collaborator

Hi @Integralist, thanks for filling the issue.
Does your issue refer to false-positives in cases like

type issue744 struct {
	c chan struct{}
	// ...other fields...
}

?
If yes, the branch fix/744 should fix the problem. Could you confirm?

@chavacava chavacava self-assigned this Sep 3, 2022
@chavacava chavacava added the bug label Sep 3, 2022
@Integralist
Copy link
Author

Hi @chavacava correct! I've noticed it specifically here where we have a struct field of chan struct{}:

https://github.com/fastly/cli/blob/c4a65100aeacabc740e5032c81034c15beed6ab3/pkg/commands/logtail/root.go#L30-L42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants