Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint issues #1038

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix lint issues #1038

merged 1 commit into from
Sep 16, 2024

Conversation

ytnsym
Copy link
Contributor

@ytnsym ytnsym commented Sep 15, 2024

Fix lint issues reported by revive

revive ./...
lint/file.go:191:22: parameter 'filename' seems to be unused, consider removing or renaming it as _
rule/datarace.go:83:3: var getIds should be getIDs

@chavacava chavacava merged commit 6b745b0 into mgechev:master Sep 16, 2024
4 checks passed
@chavacava
Copy link
Collaborator

Thanks @ytnsym

@@ -4,3 +4,4 @@ vendor
*.swp
dist/
*.log
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't commit this, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccoVeille
I have reverted the changes. #1042

@ytnsym ytnsym mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants