Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug #736: Data race in rule function-length #745

Merged
merged 1 commit into from
Sep 10, 2022
Merged

fix bug #736: Data race in rule function-length #745

merged 1 commit into from
Sep 10, 2022

Conversation

chavacava
Copy link
Collaborator

Closes #736

@chavacava chavacava requested a review from mgechev September 3, 2022 06:45
@hansgylling
Copy link

I'm not familiar with the revive code base and can't review or comment on the code. However I reported the bug that this PR fixes and I have tested the fix and can't reproduce the bug that I reported. I noticed that the branch had been updated since the test I reported in the bug report, so I have now tested the latest version of the branch.

@chavacava chavacava removed the request for review from mgechev September 10, 2022 07:08
@chavacava chavacava merged commit 3116818 into master Sep 10, 2022
@mgechev mgechev deleted the fix/736 branch October 13, 2022 15:17
@mgechev mgechev restored the fix/736 branch October 13, 2022 15:17
@mgechev mgechev deleted the fix/736 branch October 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data race in rule function-length
2 participants
@chavacava @hansgylling