Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ii log format #33

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Support ii log format #33

merged 1 commit into from
Aug 28, 2023

Conversation

cedk
Copy link
Contributor

@cedk cedk commented Aug 19, 2023

ii is a minimalist IRC client: http://tools.suckless.org/ii/

mgedmin
mgedmin reviewed Aug 21, 2023
View reviewed changes
Copy link
Owner

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sort of change where I'd feel more confident about not breaking it in the future if I had a unit test for the ii log format.

mgedmin
mgedmin approved these changes Aug 28, 2023
View reviewed changes
Copy link
Owner

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mgedmin mgedmin merged commit b30f163 into mgedmin:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedk @mgedmin