Issue 61: add option allowing specifying gc collect generation #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgedmin
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Apologies for the delayed reply. (I was on vacation, which unfortunately was too short to resolve my burnout issues.)
I like this. Some of the docstrings are missing the .. versionchanged:: directive mentioning the new parameter. I mentioned some of them, but there are more where I ran out of time.
If that's fixed, I'll merge this right away.
(I wouldn't have liked the global parameter.)
|
No worries! Sorry to hear about the burnout issues... I think I covered them all. Let me know if there is anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing this to address issue #61. It is proposed as a draft as I was considering an alternative implementation.
The proposed change here adds the
gc_collect_genargument to all functions which end up callinggc.collect().An alternative implementation would be to add a single configuration function to
objgraph, eg.set_gc_collect_gen, to set a global variable inobjgraphwhich would then be used in all calls togc.collect().I am assuming that this will become version 3.6.0.
Let me know what you think!