-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more marker traits? #4
Comments
Since #57, the I'm still unsure if implementing The other structs seem to implement everything that makes sense. |
I added it in 401a3ad |
I'm not sure if this is sound. It seems that this would allow to write/read from two different threads each, which isn't allowed for SPSC. But the "chunks" have exclusive access to producer/consumer, so maybe this is OK? If it is indeed sound, the detailed argument for that should be added as a comment. |
Are you concerning the case having chunk and producer/consumer in different thread by sending only chunk and leave producer/consumer in original thread? IMHO, the rust lifetime system doesn't allow it because of Even if you assume that the rust lifetime system allows it, we are already able to have chunk and producer/consumer in different thread without implementing So, implementing |
I think you are right, and I agree that
If you want, you can create a separate PR based on the |
Sorry for late response, I did it. |
Should the
RingBuffer
beSend
?I think this might be useful.
It could probably even be
Sync
, even though this could only be used to get its capacity. But why not?Could/should the
Producer
/Consumer
beRefUnwindSafe
?What about the other structs?
Are they missing any marker traits?
The text was updated successfully, but these errors were encountered: