Stop inlining display_width
#335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the size of Textwrap drops from 16.3 KiB to 13.5 KiB as
per `cargo bloat` on a simple “Hello World” program.
As far as I can measure, inlining `display_width` actually makes
performance slightly worse. The benchmark results jump around a
little, but we can plot them as a histogram. All numbers are
microseconds for the `fill_optimal_fit_ascii/4800` benchmark.
With the `#[inline]` attribute:
# Mean = 254.7
237 .. 240 [ 1 ]: ∎
240 .. 243 [ 1 ]: ∎
243 .. 246 [ 0 ]:
246 .. 249 [ 1 ]: ∎
249 .. 252 [ 9 ]: ∎∎∎∎∎∎∎∎∎
252 .. 255 [ 6 ]: ∎∎∎∎∎∎
255 .. 258 [ 15 ]: ∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎
258 .. 261 [ 15 ]: ∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎
261 .. 264 [ 1 ]: ∎
264 .. 267 [ 1 ]: ∎
Without the `#[inline]` attribute:
# Mean = 251.8
239 .. 241 [ 1 ]: ∎
241 .. 243 [ 1 ]: ∎
243 .. 245 [ 4 ]: ∎∎∎∎
245 .. 247 [ 4 ]: ∎∎∎∎
247 .. 249 [ 2 ]: ∎∎
249 .. 251 [ 7 ]: ∎∎∎∎∎∎∎
251 .. 253 [ 9 ]: ∎∎∎∎∎∎∎∎∎
253 .. 255 [ 3 ]: ∎∎∎
255 .. 257 [ 7 ]: ∎∎∎∎∎∎∎
257 .. 259 [ 12 ]: ∎∎∎∎∎∎∎∎∎∎∎∎
As can be seen, the mean drops by 3 microseconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the size of Textwrap drops from 16.3 KiB to 13.5 KiB as per
cargo bloaton a simple “Hello World” program.As far as I can measure, inlining
display_widthactually makes performance slightly worse. The benchmark results jump around a little, but we can plot them as a histogram. All numbers are microseconds for thefill_optimal_fit_ascii/4800benchmark.With the
#[inline]attribute:Without the
#[inline]attribute:As can be seen, the mean drops by 3 microseconds.