Preserve the build-info.json file on the gh-pages branch
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On `master`, we have an empty `build-info.json` file. When bundling the Wasm demo, this file was included in the `dist/` directory. When we later unpack this onto the `gh-pages` branch, we would end up with a dirty working copy – even if nothing else had changed since the last commit on that branch. With this change, we eliminate this source of change by restoring the `build-info.json` file after we unpack the bundle. This way we can detect if something changed in the bundle itself.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
master, we have an emptybuild-info.jsonfile. When bundlingthe Wasm demo, this file was included in the
dist/directory. Whenwe later unpack this onto the
gh-pagesbranch, we would end up witha dirty working copy – even if nothing else had changed since the last
commit on that branch.
With this change, we eliminate this source of change by restoring the
build-info.jsonfile after we unpack the bundle. This way we candetect if something changed in the bundle itself.