Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CIFuzz Github action #498

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Conversation

DavidKorczynski
Copy link
Contributor

Add CIFuzz workflow action to have fuzzers build and run on each PR. This is a service offered by OSS-Fuzz where Textwrap already runs. In the current PR the fuzzers gets build on a pull request and will run for 300 seconds.

I noticed the CI already builds and runs the fuzzers -- the benefit of CIFuzz it has a set of features that are useful e.g. only highlighting issues only if they are introduced by the given PR, using of OSS-Fuzz code corpus and more. Let me know what you think!

Signed-off-by: David Korczynski david@adalogics.com

Signed-off-by: David Korczynski <david@adalogics.com>
@mgeisler
Copy link
Owner

Hey @DavidKorczynski, this sounds great! Do I understand correctly that this will run all of our fuzz targets? How do I enable new targets in the future?

@DavidKorczynski
Copy link
Contributor Author

How do I enable new targets in the future?

The action relies on the build.sh script here: https://github.com/google/oss-fuzz/blob/master/projects/textwrap/build.sh

You can modify this script whenever you want! Do a PR on oss-fuzz and we'll merge it in. Another option is to make https://github.com/google/oss-fuzz/blob/master/projects/textwrap/build.sh call a script inside of this repo (it clones this repo anyways from the Dockerfile https://github.com/google/oss-fuzz/blob/master/projects/textwrap/Dockerfile), and, thus you can easily extend which fuzzers should be build

Signed-off-by: David Korczynski <david@adalogics.com>
@mgeisler
Copy link
Owner

You can modify this script whenever you want! Do a PR on oss-fuzz and we'll merge it in.

Nice, thanks for explaining! I think this looks nice, so let's merge it. We can then remove the "Required" flag for the old GitHub actions and thus clean this up a bit.

@mgeisler mgeisler merged commit be97687 into mgeisler:master Nov 27, 2022
@github-actions github-actions bot mentioned this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants