Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complains about alternate [dependency] blocks showing a git include #42

Closed
codyps opened this issue Oct 27, 2018 · 5 comments
Closed

complains about alternate [dependency] blocks showing a git include #42

codyps opened this issue Oct 27, 2018 · 5 comments

Comments

@codyps
Copy link

codyps commented Oct 27, 2018

For example, https://github.com/jmesmon/rust-systemd/blob/cec9df440144daf975348fb7532f88c4757ca9ec/README.md or https://github.com/jmesmon/rust-systemd/blob/bb87c893127da33cf27c32fcbfd40a40d5f9cb37/README.md

[dependencies.systemd]
git = "https://github.com/jmesmon/rust-systemd"

etc.

Marking as no_sync as a workaround, but seems plausible that version-sync could detect that one is trying to provide a git dependency and allow it.
@mgeisler
Copy link
Owner

Hi Cody,

Thanks for the report -- I agree completely, version-sync should be smart enough to ignore such dependencies. I'll see what I can come up with!

mgeisler added a commit that referenced this issue Nov 10, 2018
@mgeisler
extract_version_request: always accept Git dependencies
ebb97e9 
If a block contain a "git = '...'" dependency, then we can simply
accept it. Before we would raise a "on dependency on foo" error since
we would not detect the version number.

Fixes #42.
@ahmedcharles
Copy link

When might this be available on crates.io?

@mgeisler
Copy link
Owner

Hi @ahmedcharles, I just merged #45 to address this issue. I'll try to make a release in the next days.

@mgeisler
Copy link
Owner

@ahmedcharles, I've just published version 0.6.0 with this change and with another little feature that I've been meaning to get out. Enjoy!

@ahmedcharles
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgeisler @codyps @ahmedcharles