Drop Rust 2018 compatibility #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeisler
force-pushed
the
drop-rust-2018-compatibility
branch
from
57da168 to
7b594ab
Compare
I've been trying to keep the crate compatible with Rust 2018, which corresponds to Rust version 1.31.0. However, this has proven impossible because of how our dependencies keep releasing new patch versions that push up the minimum required Rust version. Because of this, the current code no longer compiles with Rust 1.31.0 because `cargo sync` will pull in too new versions of the direct and transitive dependencies. This happens even if there are no changes in `version-sync`. The failure to compile shows up as spurious and unexpected build failures in our CI, which in turn makes it hard to trust CI. I'm concluding that it's infeasible to keep `version-sync` compatible with any particular version of Rust. While not perfect, we'll track the latest stable version of Rust from now on. This is not perfect since even stable Rust sometimes decides to turn warnings into hard errors: rust-lang/rust#64221
mgeisler
force-pushed
the
drop-rust-2018-compatibility
branch
from
7b594ab to
908b501
Compare
The nightly tests have never managed to catch something. Since AppVeyor runs our tests one at a time, we can save some time by only running nightly tests in Linux (on Travis CI).
This takes advantage of the default match bindings in Rust 2018.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to keep the crate compatible with Rust 2018, which
corresponds to Rust version 1.31.0. However, this has proven
impossible because of how our dependencies keep releasing new patch
versions that push up the minimum required Rust version.
Because of this, the current code no longer compiles with Rust 1.31.0
because
cargo syncwill pull in too new versions of the direct andtransitive dependencies. This happens even if there are no changes in
version-sync.The failure to compile shows up as spurious and unexpected build
failures in our CI, which in turn makes it hard to trust CI.
I'm concluding that it's infeasible to keep
version-synccompatiblewith any particular version of Rust. While not perfect, we'll track
the latest stable version of Rust from now on. This is not perfect
since even stable Rust sometimes decides to turn warnings into hard
errors: rust-lang/rust#64221