Preserve slashes when encoding repo in url #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgks
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Glad you noticed the issue.
But there's a little better approach we can take here. We need encoding for other methods also including history.pushState to update web address. While we already had the repo variable with proper structure that we can simply leverage.
Thanks for the commit. 👍🏼
|
@max-programming changes are live now and your contribution with username will be added to the next release bug fixes. ✌🏼 |
|
Totally get it. And thanks a lot @mgks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on any file, the url looks like this
https://github.com/[username]%2F[repo-name]/blob/main/[file]and causes a 404Slashes are also encoded in the user/repo part
This PR solves that issue