TestClassSuffixNameRule

[Boegie]

Trying to implement #608

[Boegie]

Let's wait until somebody comments on https://www.drupal.org/project/drupal/issues/3268489#comment-15252653 about the abstract-ness of *TestBase classes.

[Boegie]

Verdict is in:

The base classes should always be abstract yes, not sure whether it's documented but it's what should happen.
catch in https://www.drupal.org/project/drupal/issues/3268489#comment-15252749

For me the rule works as expected and is ready for review.

[Boegie]

Let's see if we can do something more here by also checking for namespaces, and most importantly for tests being picked up by the test runner directory naming.
See https://www.drupal.org/project/drupal/issues/3394186#comment-15274178

[mglaman]

@Boegie I'll defer to your judgement if the baseline failures look OK. When you say it's good, I'll merge

[Boegie]

Ohh, the pressure... ;)

Thanks @mglaman, I have something cooking locally that has three rules for test classes, one for the class name (this one), one for the namespace and one for the file location.

Since they both use a lot of the same code it makes sense to me to create a base class for this, thus trying to create one PR to rule them all.

Shouldn't be long...
#FamousLastWords