Skip to content

add error handling for pause/unpause cluster #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mona-xia-cb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add error handling for pause/unpause cluster #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion atlasapi/atlas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,12 @@ def pause_cluster(self, cluster: str, toggle_if_paused: bool = False) -> dict:
elif existing_config.paused is True and toggle_if_paused is True:
logger.warning('Cluster is paused, will toggle to unpaused, since toggle_if paused is true')
new_config = dict(paused=False)
else:
elif toggle_if_paused is False:
new_config = dict(paused=True)
else:
logger.error("The cluster is unpaused. No need to unpause again.")
raise ErrAtlasBadRequest(400,
Copy link

@kxun kxun Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel there is no need to raise an exception, but I am not sure what to return.
MGM?

{'msg': 'The cluster is already unpaused. No need to unpause again.'})
return self.modify_cluster(cluster=cluster, cluster_config=new_config)

def test_failover(self, cluster: str) -> Optional[dict]:
Expand Down