-
Notifications
You must be signed in to change notification settings - Fork 21
121 reimplement hosts endpoints with new network stack #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mgmonteleone
merged 15 commits into
v3
from
121-reimplement-hosts-endpoints-with-new-network-stack
Aug 29, 2022
Merged
121 reimplement hosts endpoints with new network stack #124
mgmonteleone
merged 15 commits into
v3
from
121-reimplement-hosts-endpoints-with-new-network-stack
Aug 29, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented first changes for #121.. First 3 tests passed, moving on to next group of tests.
…to next group of tests.
…with-new-network-stack' into 121-reimplement-hosts-endpoints-with-new-network-stack
…with-new-network-stack' into 121-reimplement-hosts-endpoints-with-new-network-stack
…with-new-network-stack' into 121-reimplement-hosts-endpoints-with-new-network-stack
Partitions and databases endpoints remain.
…ts value on-the-fly (#118) This change would allow a user to do something like the following, just before making the API call, allowing them to specify the `URI_STUB` manually for endpoints that accept something other than v1.5 (for example: https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#operation/returnOneAdvancedClusterFromOneProject)
Small cleanup of settings file.
…ts-endpoints-with-new-network-stack
Owner
Author
|
@dmalik-mdb , tests are expected to fail at this point, so this should not prevent merging this in. |
dmalik-mdb
approved these changes
Aug 29, 2022
Collaborator
dmalik-mdb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed #121 , all host endpoints refactored to use new networking class.
All tests updated in the monitoring tests, and now pass.