Skip to content

Conversation

@mgmonteleone
Copy link
Owner

@mgmonteleone mgmonteleone commented Aug 28, 2022

Completed #121 , all host endpoints refactored to use new networking class.

All tests updated in the monitoring tests, and now pass.

Matthew G. Monteleone added 11 commits August 26, 2022 17:47
Implemented first changes for #121.. First 3 tests passed, moving on to next group of tests.
…with-new-network-stack' into 121-reimplement-hosts-endpoints-with-new-network-stack
…with-new-network-stack' into 121-reimplement-hosts-endpoints-with-new-network-stack
…with-new-network-stack' into 121-reimplement-hosts-endpoints-with-new-network-stack
Partitions and databases endpoints remain.
jpinsolle-bc and others added 4 commits August 28, 2022 00:38
…ts value on-the-fly (#118)

This change would allow a user to do something like the following, just before making the API call,
allowing them to specify the `URI_STUB` manually for endpoints that accept something other than v1.5
(for example:
https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#operation/returnOneAdvancedClusterFromOneProject)
Small cleanup of settings file.
@mgmonteleone
Copy link
Owner Author

@dmalik-mdb , tests are expected to fail at this point, so this should not prevent merging this in.

Copy link
Collaborator

@dmalik-mdb dmalik-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgmonteleone mgmonteleone merged commit d207ad7 into v3 Aug 29, 2022
@mgmonteleone mgmonteleone deleted the 121-reimplement-hosts-endpoints-with-new-network-stack branch August 29, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants