Skip to content

Add start/end to get_measurement_for_hosts() #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgmonteleone merged 1 commit into from
Mar 26, 2023
Merged

Add start/end to get_measurement_for_hosts() #176

mgmonteleone merged 1 commit into from
Mar 26, 2023

Conversation

@ajdavis
Copy link

@ajdavis ajdavis commented Mar 5, 2023 •
edited
Loading

Fixes #171. I couldn't figure out how to generate an API key that works with the test suite, so I'm not sure my new test works.

@mgmonteleone mgmonteleone self-assigned this Mar 26, 2023
@mgmonteleone mgmonteleone merged commit 4ce6b59 into mgmonteleone:v3 Mar 26, 2023
@mgmonteleone mgmonteleone mentioned this pull request Mar 26, 2023
Closed
mgmonteleone pushed a commit that referenced this pull request Mar 26, 2023
Fixing #178, test 12 fixed. Parameter handling was missign after URI …
de48e2d 
…was changed in PR #176,
mgmonteleone pushed a commit that referenced this pull request Mar 26, 2023
178 regression et al (#180)
e2a048c 
* Fixed #177

* Fixing #178, test 12 fixed. Parameter handling was missign after URI was changed in PR #176,

* Fixed #178 tests fixed, needed to refactor how multiple measurements are set. Much improved `params` based .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mgmonteleone mgmonteleone

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajdavis @mgmonteleone