fix(reporters): Revert the backwards-incompatible log priority order …

…changes Commit 35965d9 changed the order of log priorities, making lots of configurations no longer print console.log messages. This was a backwards-incompatible change which this commit reverts. Tests were added to ensure the proper order is respected. Fixes karma-runner#2582
mgol · Apr 26, 2017 · 316b944 · 316b944
1 parent ef62da9
commit 316b944
Show file tree

Hide file tree

Showing 3 changed files with 58 additions and 9 deletions.
diff --git a/lib/constants.js b/lib/constants.js
@@ -20,9 +20,9 @@ exports.LOG_PRIORITIES = [
   exports.LOG_DISABLE,
   exports.LOG_ERROR,
   exports.LOG_WARN,
+  exports.LOG_LOG,
   exports.LOG_INFO,
-  exports.LOG_DEBUG,
-  exports.LOG_LOG
+  exports.LOG_DEBUG
 ]
 
 // Default patterns for the pattern layout.

diff --git a/test/e2e/browser_console.feature b/test/e2e/browser_console.feature
@@ -11,10 +11,7 @@ Feature: Browser Console Configuration
       plugins = [
         'karma-jasmine',
         'karma-phantomjs-launcher'
-      ],
-      browserConsoleLogOptions = {
-        level: 'log'
-      };
+      ];
       """
     When I start Karma
     Then it passes with like:

diff --git a/test/unit/reporters/base.spec.js b/test/unit/reporters/base.spec.js
@@ -103,6 +103,19 @@ describe('reporter', function () {
       }, adapter)
       var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
 
+      reporter._browsers = ['Chrome']
+      reporter.onBrowserLog('Chrome', 'Message', 'LOG')
+
+      return writeSpy.should.have.not.been.called
+    })
+
+    it('should not log if lower priority than browserConsoleLogOptions "log"', function () {
+      var reporter = new m.BaseReporter(null, null, true, {
+        level: 'log',
+        terminal: true
+      }, adapter)
+      var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
+
       reporter._browsers = ['Chrome']
       reporter.onBrowserLog('Chrome', 'Message', 'INFO')
 
@@ -122,17 +135,56 @@ describe('reporter', function () {
       return writeSpy.should.have.not.been.called
     })
 
-    it('should not log if lower priority than browserConsoleLogOptions "debug"', function () {
+    it('should log if higher priority than browserConsoleLogOptions "warn"', function () {
       var reporter = new m.BaseReporter(null, null, true, {
-        level: 'debug',
+        level: 'warn',
+        terminal: true
+      }, adapter)
+      var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
+
+      reporter._browsers = ['Chrome']
+      reporter.onBrowserLog('Chrome', 'Message', 'ERROR')
+
+      return writeSpy.should.have.been.called
+    })
+
+    it('should log if higher priority than browserConsoleLogOptions "log"', function () {
+      var reporter = new m.BaseReporter(null, null, true, {
+        level: 'log',
+        terminal: true
+      }, adapter)
+      var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
+
+      reporter._browsers = ['Chrome']
+      reporter.onBrowserLog('Chrome', 'Message', 'WARN')
+
+      return writeSpy.should.have.been.called
+    })
+
+    it('should log if higher priority than browserConsoleLogOptions "info"', function () {
+      var reporter = new m.BaseReporter(null, null, true, {
+        level: 'info',
         terminal: true
       }, adapter)
       var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
 
       reporter._browsers = ['Chrome']
       reporter.onBrowserLog('Chrome', 'Message', 'LOG')
 
-      return writeSpy.should.have.not.been.called
+      return writeSpy.should.have.been.called
+    })
+
+    it('should log if higher priority than browserConsoleLogOptions "debug"', function () {
+      var reporter = new m.BaseReporter(null, null, true, {
+        level: 'debug',
+        terminal: true
+      }, adapter)
+      var writeSpy = sinon.spy(reporter, 'writeCommonMsg')
+
+      reporter._browsers = ['Chrome']
+      reporter.onBrowserLog('Chrome', 'Message', 'INFO')
+
+      return writeSpy.should.have.been.called
     })
 
     return it('should format log messages correctly for multi browsers', function () {