Weird behaviour when using non-English keyboard layout (likely cause Todoist shortcuts persist)

[anton2020]

Hey there!
First, thanks for the great extension. I'm using two keyboard layouts (US English and Russian) on a daily basis and I've noticed that sometimes when I forget that my keyboard is in the Russian layout and press a button while in Todoist (and your extension is not intended to work with non-English layouts, right?), something unexpected happens — so this extension kinda works but strangely...

For example, if I go to my Inbox, select a task and press "d" I complete it. However, if I press "в" on the Russian layout instead (same key) then all Inbox items get "sorted by due date".

Do you know if I could fix it somehow? Either by disabling the non-English keyboard layout or by having it respond the same way as English one?

PS: I just tried disabling your shortcut completely and the "if I press "в" on the Russian layout" thing persists! Seems like the original mapping for "d" shortcut works for the Russian layout while your extension changes behaviour for English one.

Do you know if I can do anything about it? Thanks in advance!

[anton2020]

UPD: I actually think disabling the default Todoist shortcuts will help solve this issue. Does anyone know if / how one could turn them off?

[adamleerich]

Do package users want the extension to turn off Todoist's built-in shortcut commands? If so, that is something that I'd be happy to try and figure out. :)

[mgsloan]

Sure, that'd be awesome Adam! I have tried before but didn't figure out a reliable way to do it.

…

On Sun, Sep 12, 2021 at 11:02 PM Adam Rich ***@***.***> wrote: Do package users want the extension to turn off Todoist's built-in shortcut commands? If so, that is something that I'd be happy to try and figure out. :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#180 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFQKWMVVAOTEZIQCD2DG3UBWAXBANCNFSM5BJKZRKQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[mgsloan]

It's possible this might be fixed with the latest extension version (134 or 135), can you verify?

[mgsloan]

🤔 Closing this issue

[anton2020]

Hello @mgsloan ! I am not sure why you assigned this issue to me? Hence I removed my assignment.
However, this bug I described still persists for a non-English keyboard layout. Shall the issue be reopened?

[anton2020]

Okay, seems like there was a misunderstanding on my side. Following up on @mgsloan reply from 8 days ago about versions 134-135: the unexpected behaviour I described still persists in version 137 (pressing "d" and Russian layout's "в" yields different results).

Sorry for my initial confusion, I am not used to Github's functionality yet.

[mgsloan]

No worries! I've re-opened the issue.

I think it would be best to fix this issue upstream, todoist-shortcuts uses a library called mousetrap for its keypress handling - and there are a few issues on the repository I found via this search:

• Unsupported keyboard layout · Issue #227 · ccampbell/mousetrap
• how to make this work with keyboard layout like Japanese? · Issue #453 · ccampbell/mousetrap
• alt+7, alt+8, alt+9 does not work in Chrome & Safari (swedish keyboard layout) · Issue #334 · ccampbell/mousetrap
• Not works key tilda ( ` or ~) in cyrillic keybord layout (Firefox 22) · Issue #143 · ccampbell/mousetrap
• Problems with keyboard layouts · Issue #191 · ccampbell/mousetrap

Given that that repo has 10K stars no doubt the highest impact thing would be to fix it there. Unfortunately I am guessing it is probably a tricky problem to fix.