Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naive fix for ID that treats it as a String #4

Merged
merged 6 commits into from
Sep 9, 2017
Merged

Naive fix for ID that treats it as a String #4

merged 6 commits into from
Sep 9, 2017

Conversation

ulrikstrid
Copy link
Contributor

If you want me to change less stuff I can create a new PR

@ulrikstrid
Copy link
Contributor Author

Might not be as naive as I thought. From graphql.org

ID: The ID scalar type represents a unique identifier, often used to refetch an object or as the key for a cache. The ID type is serialized in the same way as a String; however, defining it as an ID signifies that it is not intended to be human‐readable.

@ulrikstrid ulrikstrid mentioned this pull request Sep 8, 2017
Closed
@wokalski
Copy link
Contributor

wokalski commented Sep 8, 2017

Additionally we added support for custom scalars (they are just Js.Json.t for now) and first class support for Booleans.

@wokalski
Copy link
Contributor

wokalski commented Sep 8, 2017

Fixes #2 and #3

@mhallin
Copy link
Owner

mhallin commented Sep 9, 2017

Thanks a lot for these fixes! I'll merge this and get things ready for a new opam release.

@mhallin mhallin merged commit 8398120 into mhallin:master Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulrikstrid @wokalski @mhallin