Fix undefined names reported by Flake8/Ruff (#2101)

Co-authored-by: kxrob <kxroberto@gmail.com>

Pythonwin/pywin/Demos/cmdserver.py

@@ -106,10 +106,10 @@ def ServerThread(myout, cmd, title, bCloseOnEnd):
 
 # assist for reloading (when debugging) - use only 1 tracer object,
 # else a large chain of tracer objects will exist.
-# try:
-# 	writer
-# except NameError:
-# 	writer=ThreadWriter()
+try:
+    writer
+except NameError:
+    writer = ThreadWriter()
 if __name__ == "__main__":
     import demoutils
 

Pythonwin/pywin/Demos/fontdemo.py

@@ -43,7 +43,7 @@ def SetFont(self, new_font):
         # Change font on the fly
         self.font = win32ui.CreateFont(new_font)
         # redraw the entire client window
-        selfInvalidateRect(None)
+        self.InvalidateRect(None)
 
     def OnSize(self, params):
         lParam = params[3]

Pythonwin/pywin/Demos/ocx/msoffice.py

@@ -7,13 +7,9 @@
 import win32con
 import win32ui
 import win32uiole
-from pywin.mfc import docview, object, window
+from pywin.mfc import activex, docview, object, window
 from win32com.client import gencache
 
-# WordModule = gencache.EnsureModule('{00020905-0000-0000-C000-000000000046}', 1033, 8, 0)
-# if WordModule is None:
-# 	raise ImportError, "Microsoft Word version 8 does not appear to be installed."
-
 
 class OleClientItem(object.CmdTarget):
     def __init__(self, doc):
@@ -122,6 +118,17 @@ def __init__(self, doc=None):
         # Dont call base class doc/view version...
 
     def Create(self, title, rect=None, parent=None):
+        WordModule = gencache.EnsureModule(
+            "{00020905-0000-0000-C000-000000000046}", 1033, 8, 0
+        )
+        if WordModule is None:
+            raise ImportError(
+                "Microsoft Word version 8 does not appear to be installed."
+            )
+
+        # WordModule.Word doesn't exist in WordModule, WordModule.Words does, but CreateControl still fails
+        class MyWordControl(activex.Control, WordModule.Word): ...
+
         style = win32con.WS_CHILD | win32con.WS_VISIBLE | win32con.WS_OVERLAPPEDWINDOW
         self._obj_.CreateWindow(None, title, style, rect, parent)
 
@@ -141,11 +148,12 @@ def Demo():
     docName = None
     if len(sys.argv) > 1:
         docName = win32api.GetFullPathName(sys.argv[1])
-    OleTemplate().OpenDocumentFile(None)
+    OleTemplate().OpenDocumentFile(docName)
 
+    # ActiveX not currently working
+    # f = WordFrame(docName)
+    # f.Create("Microsoft Office")
 
-# 	f = WordFrame(docName)
-# 	f.Create("Microsoft Office")
 
 if __name__ == "__main__":
     Demo()

Pythonwin/pywin/Demos/ocx/ocxtest.py

@@ -228,12 +228,6 @@ def test2():
     d = None
 
 
-def test3():
-    d = TestCOMMDialog(MakeDlgTemplate())
-    d.DoModal()
-    d = None
-
-
 def testall():
     test1()
     test2()

Pythonwin/pywin/debugger/__init__.py

@@ -1,11 +1,5 @@
 import sys
 
-
-# Some cruft to deal with the Pythonwin GUI booting up from a non GUI app.
-def _MakeDebuggerGUI():
-    app.InitInstance()
-
-
 isInprocApp = -1
 
 

Pythonwin/pywin/dialogs/ideoptions.py

@@ -115,25 +115,25 @@ def OnFormatTitle(self, command, code):
         fmt = self.GetFormat(interact.formatTitle)
         if fmt:
             formatTitle = fmt
-            SaveFontPreferences()
+            interact.SaveFontPreferences()
 
     def OnFormatInput(self, command, code):
         global formatInput
         fmt = self.GetFormat(formatInput)
         if fmt:
             formatInput = fmt
-            SaveFontPreferences()
+            interact.SaveFontPreferences()
 
     def OnFormatOutput(self, command, code):
         global formatOutput
         fmt = self.GetFormat(formatOutput)
         if fmt:
             formatOutput = fmt
-            SaveFontPreferences()
+            interact.SaveFontPreferences()
 
     def OnFormatError(self, command, code):
         global formatOutputError
         fmt = self.GetFormat(formatOutputError)
         if fmt:
             formatOutputError = fmt
-            SaveFontPreferences()
+            interact.SaveFontPreferences()

Pythonwin/pywin/framework/dlgappcore.py

@@ -27,12 +27,14 @@ def OnInitDialog(self):
     def OnPaint(self):
         if not self.IsIconic():
             return self._obj_.OnPaint()
+        dc, paintStruct = self.BeginPaint()
         self.DefWindowProc(win32con.WM_ICONERASEBKGND, dc.GetHandleOutput(), 0)
         left, top, right, bottom = self.GetClientRect()
         left = (right - win32api.GetSystemMetrics(win32con.SM_CXICON)) >> 1
         top = (bottom - win32api.GetSystemMetrics(win32con.SM_CYICON)) >> 1
         hIcon = win32ui.GetApp().LoadIcon(self.iconId)
-        self.GetDC().DrawIcon((left, top), hIcon)
+        dc.DrawIcon((left, top), hIcon)
+        self.EndPaint(paintStruct)
 
     # Only needed to provide a minimized icon (and this seems
     # less important under win95/NT4

Pythonwin/pywin/framework/interact.py

@@ -76,6 +76,15 @@ def SavePreference(prefName, prefValue):
     win32ui.WriteProfileVal(sectionProfile, prefName, prefValue)
 
 
+def SaveFontPreferences():
+    win32ui.WriteProfileVal(sectionProfile, valueFormatTitle, str(formatTitle))
+    win32ui.WriteProfileVal(sectionProfile, valueFormatInput, str(formatInput))
+    win32ui.WriteProfileVal(sectionProfile, valueFormatOutput, str(formatOutput))
+    win32ui.WriteProfileVal(
+        sectionProfile, valueFormatOutputError, str(formatOutputError)
+    )
+
+
 def GetPromptPrefix(line):
     ps1 = sys.ps1
     if line[: len(ps1)] == ps1:
@@ -333,7 +342,7 @@ def Init(self):
                     )
                 )
             else:
-                sys.stderr.write(banner)
+                sys.stderr.write(self.banner)
         rcfile = os.environ.get("PYTHONSTARTUP")
         if rcfile:
             import __main__

Pythonwin/pywin/framework/mdi_pychecker.py

@@ -38,6 +38,7 @@
 import re
 import sys
 import time
+from functools import reduce
 
 import win32api
 import win32con

Pythonwin/pywin/scintilla/configui.py

@@ -286,7 +286,7 @@ def OnOK(self):
 
 
 def test():
-    page = ColorEditorPropertyPage()
-    sheet = pywin.mfc.dialog.PropertySheet("Test")
+    page = ScintillaFormatPropertyPage()
+    sheet = dialog.PropertySheet("Test")
     sheet.AddPage(page)
     sheet.CreateWindow()

Pythonwin/pywin/scintilla/scintillacon.py

@@ -1,23 +1,5 @@
 # Generated by h2py from Include\scintilla.h
 
-
-# Included from BaseTsd.h
-def HandleToUlong(h):
-    return HandleToULong(h)
-
-
-def UlongToHandle(ul):
-    return ULongToHandle(ul)
-
-
-def UlongToPtr(ul):
-    return ULongToPtr(ul)
-
-
-def UintToPtr(ui):
-    return UIntToPtr(ui)
-
-
 INVALID_POSITION = -1
 SCI_START = 2000
 SCI_OPTIONAL_START = 3000

Pythonwin/pywin/tools/TraceCollector.py

@@ -49,11 +49,11 @@ def _StopThread(self):
     def Close(self):
         self._StopThread()
         winout.WindowOutput.Close(self)
-        # 	def OnViewDestroy(self, frame):
-        # 		return winout.WindowOutput.OnViewDestroy(self, frame)
-        # 	def Create(self, title=None, style = None):
-        # 		rc = winout.WindowOutput.Create(self, title, style)
-        return rc
+        # def OnViewDestroy(self, frame):
+        #     return winout.WindowOutput.OnViewDestroy(self, frame)
+        # def Create(self, title=None, style = None):
+        #     rc = winout.WindowOutput.Create(self, title, style)
+        #     return rc
 
 
 def MakeOutputWindow():

com/win32com/readme.html

@@ -36,7 +36,7 @@ <h3>VARIANT objects</h3>
 Up until build 212, code could set <code>pythoncom.__future_currency__ = True</code>
 to force use of the decimal module, with a warning issued otherwise.  In 
 builds 213 and later, the decimal module is unconditionally used when
-pythoncon returns you a currency value.
+pythoncom returns you a currency value.
 </p>
 
 <h3>Recent Changes</h3>

com/win32com/test/daodump.py

@@ -1,6 +1,7 @@
 # import dao3032
 # No longer imported here - callers responsibility to load
 #
+import pythoncom
 import win32com.client
 
 

com/win32com/test/testClipboard.py

@@ -68,8 +68,7 @@ def QueryGetData(self, fe):
         return None  # should check better
 
     def GetCanonicalFormatEtc(self, fe):
-        RaiseCOMException(winerror.DATA_S_SAMEFORMATETC)
-        # return fe
+        raise COMException(winerror.DATA_S_SAMEFORMATETC)
 
     def SetData(self, fe, medium):
         raise COMException(hresult=winerror.E_NOTIMPL)

com/win32com/test/testGatewayAddresses.py

@@ -76,7 +76,7 @@ class Dummy2:
     ]
 
 
-class DeletgatedDummy:
+class DelegatedDummy:
     _public_methods_ = []
 
 

com/win32comext/axscript/client/pydumper.py

@@ -13,6 +13,10 @@
 # as a scripting language - meaning the dumps produced can be quite dynamic,
 # and based on the script code you execute.
 
+import sys
+
+import win32api
+import win32con
 from win32com.axscript import axscript
 
 from . import pyscript
@@ -34,8 +38,6 @@ class PyScript(pyscript.PyScript):
 
 
 def Register():
-    import sys
-
     if "-d" in sys.argv:
         dispatcher = "DispatcherWin32trace"
         debug_desc = " (" + dispatcher + ")"
@@ -51,7 +53,7 @@ def Register():
     policy = None  # "win32com.axscript.client.axspolicy.AXScriptPolicy"
 
     print("Registering COM server%s..." % debug_desc)
-    from win32com.server.register import RegisterServer
+    from win32com.server.register import RegisterServer, _set_string
 
     languageName = "PyDump"
     verProgId = "Python.Dumper.1"
@@ -66,10 +68,10 @@ def Register():
         dispatcher=dispatcher,
     )
 
-    CreateRegKey(languageName + "\\OLEScript")
+    win32api.RegCreateKey(win32con.HKEY_CLASSES_ROOT, languageName + "\\OLEScript")
     # Basic Registration for wsh.
-    win32com.server.register._set_string(".pysDump", "pysDumpFile")
-    win32com.server.register._set_string("pysDumpFile\\ScriptEngine", languageName)
+    _set_string(".pysDump", "pysDumpFile")
+    _set_string("pysDumpFile\\ScriptEngine", languageName)
     print("Dumping Server registered.")
 
 

com/win32comext/shell/demos/servers/context_menu.py

@@ -49,7 +49,7 @@ def QueryContextMenu(self, hMenu, indexMenu, idCmdFirst, idCmdLast, uFlags):
         elif uFlags & shellcon.CMF_EXPLORE:
             print("CMF_EXPLORE...")
             items.append(msg + " - normal file, right-click in Explorer")
-        elif uFlags & CMF_DEFAULTONLY:
+        elif uFlags & shellcon.CMF_DEFAULTONLY:
             print("CMF_DEFAULTONLY...\r\n")
         else:
             print("** unknown flags", uFlags)

com/win32comext/shell/demos/servers/shell_view.py

@@ -849,7 +849,7 @@ def CreateViewWindow(self, prev, settings, browser, rect):
         }
         #        win32gui.SetWindowLong(self.hwnd, win32con.GWL_WNDPROC, message_map)
 
-        file_data = file(self.filename, "U").read()
+        file_data = open(self.filename, "U").read()
 
         self._SetupLexer()
         self._SendSci(scintillacon.SCI_ADDTEXT, len(file_data), file_data)

isapi/install.py

@@ -208,8 +208,8 @@ def GetWebServer(description=None):
 def LoadWebServer(path):
     try:
         server = GetObject(path)
-    except pythoncom.com_error as details:
-        msg = details.strerror
+    except pythoncom.com_error as exc:
+        msg = exc.strerror
         if exc.excepinfo and exc.excepinfo[2]:
             msg = exc.excepinfo[2]
         msg = f"WebServer {path}: {msg}"